From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: linux-next: build warning after merge of the tree Date: Sun, 28 Mar 2010 19:15:44 -0700 Message-ID: <1269828944.1500.105.camel@Joe-Laptop.home> References: <20100329103139.1a735227.sfr@canb.auug.org.au> <20100328.185707.161194820.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.perches.com ([173.55.12.10]:1194 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827Ab0C2CPq (ORCPT ); Sun, 28 Mar 2010 22:15:46 -0400 In-Reply-To: <20100328.185707.161194820.davem@davemloft.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: David Miller Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, kyle@mcmartin.ca On Sun, 2010-03-28 at 18:57 -0700, David Miller wrote: > From: Stephen Rothwell > > After merging the tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > drivers/net/tulip/uli526x.c: In function 'uli526x_rx_packet': > > drivers/net/tulip/uli526x.c:861: warning: assignment makes pointer from integer without a cast > I just committed the following, let me know if it fixes > this. > - ((new_skb = dev_alloc_skb(rxlen + 2) != NULL))) { > + (((new_skb = dev_alloc_skb(rxlen + 2)) != NULL))) { You've an extra () there. A close paren could have been moved from after the NULL to after the "+ 2" I think it's more readable as: (new_skb = dev_alloc_skb(rxlen + 2))) { cheers, Joe