linux-next: build failure after merge of the backlight tree

linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

Hi Richard,

After merging the backlight tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/video/backlight/adp8860_bl.c: In function 'adp8860_led_probe':
drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of function 'kzalloc'
drivers/video/backlight/adp8860_bl.c:215: warning: assignment makes pointer from integer without a cast
drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of function 'kfree'
drivers/video/backlight/adp8860_bl.c: In function 'adp8860_probe':
drivers/video/backlight/adp8860_bl.c:673: warning: assignment makes pointer from integer without a cast
drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to function 'backlight_device_register'

Caused by commit 6f1a02240dba279a389fd4a4138445bd3f13f67f ("backlight:
new driver for the ADP8860 backlight parts").  Use of kzalloc or kfree
requires including linux/slab.h (see Rule 1 in
Documentation/SubmitChecklist) and the prototype of
backlight_device_register changed before v2.6.34-rc2.

Was this even build tested?

I have used the version of the backlight tree from next-20100507 for
today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 1325 bytes --]

On Sunday 09 May 2010 22:43:04 Stephen Rothwell wrote:
> After merging the backlight tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/video/backlight/adp8860_bl.c: In function 'adp8860_led_probe':
> drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of
> function 'kzalloc' drivers/video/backlight/adp8860_bl.c:215: warning:
> assignment makes pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of
> function 'kfree' drivers/video/backlight/adp8860_bl.c: In function
> 'adp8860_probe': drivers/video/backlight/adp8860_bl.c:673: warning:
> assignment makes pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to
> function 'backlight_device_register'
> 
> Caused by commit 6f1a02240dba279a389fd4a4138445bd3f13f67f ("backlight:
> new driver for the ADP8860 backlight parts").  Use of kzalloc or kfree
> requires including linux/slab.h (see Rule 1 in
> Documentation/SubmitChecklist) and the prototype of
> backlight_device_register changed before v2.6.34-rc2.

obviously the driver simply missed the tree-wide slab.h updates

Richard: you want a new version to replace the one in your tree ?  or a one 
line fix for this issue ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Hi Richard,

On Mon, 10 May 2010 12:43:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the backlight tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/video/backlight/adp8860_bl.c: In function 'adp8860_led_probe':
> drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of function 'kzalloc'
> drivers/video/backlight/adp8860_bl.c:215: warning: assignment makes pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of function 'kfree'
> drivers/video/backlight/adp8860_bl.c: In function 'adp8860_probe':
> drivers/video/backlight/adp8860_bl.c:673: warning: assignment makes pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to function 'backlight_device_register'
> 
> Caused by commit 6f1a02240dba279a389fd4a4138445bd3f13f67f ("backlight:
> new driver for the ADP8860 backlight parts").  Use of kzalloc or kfree
> requires including linux/slab.h (see Rule 1 in
> Documentation/SubmitChecklist) and the prototype of
> backlight_device_register changed before v2.6.34-rc2.

I am still getting these build failures ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Richard Purdie]

On Mon, 2010-05-17 at 13:32 +1000, Stephen Rothwell wrote:
> On Mon, 10 May 2010 12:43:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the backlight tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/video/backlight/adp8860_bl.c: In function 'adp8860_led_probe':
> > drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of function 'kzalloc'
> > drivers/video/backlight/adp8860_bl.c:215: warning: assignment makes pointer from integer without a cast
> > drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of function 'kfree'
> > drivers/video/backlight/adp8860_bl.c: In function 'adp8860_probe':
> > drivers/video/backlight/adp8860_bl.c:673: warning: assignment makes pointer from integer without a cast
> > drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to function 'backlight_device_register'
> > 
> > Caused by commit 6f1a02240dba279a389fd4a4138445bd3f13f67f ("backlight:
> > new driver for the ADP8860 backlight parts").  Use of kzalloc or kfree
> > requires including linux/slab.h (see Rule 1 in
> > Documentation/SubmitChecklist) and the prototype of
> > backlight_device_register changed before v2.6.34-rc2.
> 
> I am still getting these build failures ...

Sorry about that. A bad combination of travel with limited internet
access followed by illness. I've pushed a fix, thanks.

Richard

Re: linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

Hi Richard,

On Tue, 18 May 2010 08:54:24 -0700 Richard Purdie <rpurdie@rpsys.net> wrote:
>
> Sorry about that. A bad combination of travel with limited internet
> access followed by illness. I've pushed a fix, thanks.

Thanks for that.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hi Lee,

After merging the backlight tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/video/backlight/backlight.c: In function 'of_find_backlight_by_node':
drivers/video/backlight/backlight.c:563:2: error: implicit declaration of function 'of_platform_device_ensure' [-Werror=implicit-function-declaration]
  of_platform_device_ensure(node);
  ^

Caused by commit 67a6b10546ea ("backlight: Probe backlight devices on
demand").

I have used the backlight tree from next-20150526 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Lee Jones]

On Wed, 27 May 2015, Stephen Rothwell wrote:
> After merging the backlight tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/video/backlight/backlight.c: In function 'of_find_backlight_by_node':
> drivers/video/backlight/backlight.c:563:2: error: implicit declaration of function 'of_platform_device_ensure' [-Werror=implicit-function-declaration]
>   of_platform_device_ensure(node);
>   ^
> 
> Caused by commit 67a6b10546ea ("backlight: Probe backlight devices on
> demand").

Yes, I need to remove that commit.  Thanks for letting me know.

> I have used the backlight tree from next-20150526 for today.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hi all,

After merging the backlight tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
    8 | #include <linux/leds-expresswire.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")

I have used the backlight tree from next-20240223 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi all,

On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the backlight tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
>     8 | #include <linux/leds-expresswire.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> 
> I have used the backlight tree from next-20240223 for today.

I am still getting this failure.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Lee Jones]

On Tue, 05 Mar 2024, Stephen Rothwell wrote:

> Hi all,
> 
> On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the backlight tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
> >     8 | #include <linux/leds-expresswire.h>
> >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Caused by commit
> > 
> >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > 
> > I have used the backlight tree from next-20240223 for today.
> 
> I am still getting this failure.

I just pushed a bunch of patches.

Please let me know if this is still an issue tomorrow.

-- 
Lee Jones [李琼斯]

Re: linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

Hi Lee,

On Tue, 5 Mar 2024 09:17:37 +0000 Lee Jones <lee@kernel.org> wrote:
> On Tue, 05 Mar 2024, Stephen Rothwell wrote:
> > On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > After merging the backlight tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > > 
> > > drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
> > >     8 | #include <linux/leds-expresswire.h>
> > >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > 
> > > Caused by commit
> > > 
> > >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > > 
> > > I have used the backlight tree from next-20240223 for today.  
> > 
> > I am still getting this failure.  
> 
> I just pushed a bunch of patches.

I saw only 3 new ones (forgot to push?) none of which addressed this
problem.

> Please let me know if this is still an issue tomorrow.

The problem is that after Feb 23, you rebased your tree and dropped commit

  25ae5f5f4168 ("leds: Introduce ExpressWire library")

which (added the leds-expresswire.h header), but kept commit

  48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")

which uses it.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1935 bytes --]

Hi Lee,

On Wed, 6 Mar 2024 09:55:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 5 Mar 2024 09:17:37 +0000 Lee Jones <lee@kernel.org> wrote:
> > On Tue, 05 Mar 2024, Stephen Rothwell wrote:  
> > > On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> > > >
> > > > After merging the backlight tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > > 
> > > > drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
> > > >     8 | #include <linux/leds-expresswire.h>
> > > >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > 
> > > > Caused by commit
> > > > 
> > > >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > > > 
> > > > I have used the backlight tree from next-20240223 for today.    
> > > 
> > > I am still getting this failure.    
> > 
> > I just pushed a bunch of patches.  
> 
> I saw only 3 new ones (forgot to push?) none of which addressed this
> problem.
> 
> > Please let me know if this is still an issue tomorrow.  
> 
> The problem is that after Feb 23, you rebased your tree and dropped commit
> 
>   25ae5f5f4168 ("leds: Introduce ExpressWire library")
> 
> which (added the leds-expresswire.h header), but kept commit
> 
>   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> 
> which uses it.

Now I see what happened.  I have 2 trees from you, the backlight tree
(git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git#for-backlight-next)
and the leds-lj tree
(git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git#for-leds-next)
and the former implicitly depends on the latter (and I merge the
backlight tree first).  You should make that dependency explicit by
merging (part of) the latter into the former (or something).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the backlight tree

[Lee Jones]

On Wed, 06 Mar 2024, Stephen Rothwell wrote:

> Hi Lee,
> 
> On Wed, 6 Mar 2024 09:55:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 5 Mar 2024 09:17:37 +0000 Lee Jones <lee@kernel.org> wrote:
> > > On Tue, 05 Mar 2024, Stephen Rothwell wrote:  
> > > > On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> > > > >
> > > > > After merging the backlight tree, today's linux-next build (x86_64
> > > > > allmodconfig) failed like this:
> > > > > 
> > > > > drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
> > > > >     8 | #include <linux/leds-expresswire.h>
> > > > >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > 
> > > > > Caused by commit
> > > > > 
> > > > >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > > > > 
> > > > > I have used the backlight tree from next-20240223 for today.    
> > > > 
> > > > I am still getting this failure.    
> > > 
> > > I just pushed a bunch of patches.  
> > 
> > I saw only 3 new ones (forgot to push?) none of which addressed this
> > problem.
> > 
> > > Please let me know if this is still an issue tomorrow.  
> > 
> > The problem is that after Feb 23, you rebased your tree and dropped commit
> > 
> >   25ae5f5f4168 ("leds: Introduce ExpressWire library")
> > 
> > which (added the leds-expresswire.h header), but kept commit
> > 
> >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > 
> > which uses it.
> 
> Now I see what happened.  I have 2 trees from you, the backlight tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git#for-backlight-next)
> and the leds-lj tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git#for-leds-next)
> and the former implicitly depends on the latter (and I merge the
> backlight tree first).  You should make that dependency explicit by
> merging (part of) the latter into the former (or something).

Right.  So you build each tree as its merged?

My assumption was that all things come together in -next?

-- 
Lee Jones [李琼斯]

Re: linux-next: build failure after merge of the backlight tree

[Lee Jones]

On Thu, 07 Mar 2024, Lee Jones wrote:

> On Wed, 06 Mar 2024, Stephen Rothwell wrote:
> 
> > Hi Lee,
> > 
> > On Wed, 6 Mar 2024 09:55:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > On Tue, 5 Mar 2024 09:17:37 +0000 Lee Jones <lee@kernel.org> wrote:
> > > > On Tue, 05 Mar 2024, Stephen Rothwell wrote:  
> > > > > On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> > > > > >
> > > > > > After merging the backlight tree, today's linux-next build (x86_64
> > > > > > allmodconfig) failed like this:
> > > > > > 
> > > > > > drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linux/leds-expresswire.h: No such file or directory
> > > > > >     8 | #include <linux/leds-expresswire.h>
> > > > > >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > > > 
> > > > > > Caused by commit
> > > > > > 
> > > > > >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > > > > > 
> > > > > > I have used the backlight tree from next-20240223 for today.    
> > > > > 
> > > > > I am still getting this failure.    
> > > > 
> > > > I just pushed a bunch of patches.  
> > > 
> > > I saw only 3 new ones (forgot to push?) none of which addressed this
> > > problem.
> > > 
> > > > Please let me know if this is still an issue tomorrow.  
> > > 
> > > The problem is that after Feb 23, you rebased your tree and dropped commit
> > > 
> > >   25ae5f5f4168 ("leds: Introduce ExpressWire library")
> > > 
> > > which (added the leds-expresswire.h header), but kept commit
> > > 
> > >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > > 
> > > which uses it.
> > 
> > Now I see what happened.  I have 2 trees from you, the backlight tree
> > (git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git#for-backlight-next)
> > and the leds-lj tree
> > (git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git#for-leds-next)
> > and the former implicitly depends on the latter (and I merge the
> > backlight tree first).  You should make that dependency explicit by
> > merging (part of) the latter into the former (or something).
> 
> Right.  So you build each tree as its merged?
> 
> My assumption was that all things come together in -next?

Okay, all patches are now shared between both branches.

Let me know if there is still an issue.

-- 
Lee Jones [李琼斯]

Re: linux-next: build failure after merge of the backlight tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

Hi Lee,

On Thu, 7 Mar 2024 09:04:46 +0000 Lee Jones <lee@kernel.org> wrote:
>
> On Thu, 07 Mar 2024, Lee Jones wrote:
> 
> > Right.  So you build each tree as its merged?

More or less.  I do some batches of merges (since otherwise it just
takes way to long).

> > My assumption was that all things come together in -next? 

This is from my daily summary report:

"Between each merge, the tree was built with a ppc64_defconfig
for powerpc, an allmodconfig for x86_64, a multi_v7_defconfig for arm
and a native build of tools/perf."

> Okay, all patches are now shared between both branches.

Thanks.

> Let me know if there is still an issue.

Will do.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]