microblaze FAULT: memblock: Introduce for_each_memblock() and new accessors, and use it

microblaze FAULT: memblock: Introduce for_each_memblock() and new accessors, and use it

[Michal Simek]

Hi Ben,

your commit 53e16bfaf19346f59b3502e207aa66c61332075c in linux-next
breaks microblaze kernel compilation. It is easy to remove. Patch is 
below. Please add this change to your commit.

Thanks,
Michal

diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
index 10bae6e..840026c 100644
--- a/arch/microblaze/mm/init.c
+++ b/arch/microblaze/mm/init.c
@@ -143,7 +143,7 @@ void __init setup_memory(void)

         /* reserve allocate blocks */
         for_each_memblock(reserved, reg) {
-               pr_debug("reserved %d - 0x%08x-0x%08x\n", i,
+               pr_debug("reserved - 0x%08x-0x%08x\n",
                          (u32) reg->base, (u32) reg->size);
                 reserve_bootmem(reg->base, reg->size, BOOTMEM_DEFAULT);
         }


-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

Re: microblaze FAULT: memblock: Introduce for_each_memblock() and new accessors, and use it

[Benjamin Herrenschmidt]

On Mon, 2010-08-02 at 12:25 +0200, Michal Simek wrote:
> Hi Ben,
> 
> your commit 53e16bfaf19346f59b3502e207aa66c61332075c in linux-next
> breaks microblaze kernel compilation. It is easy to remove. Patch is 
> below. Please add this change to your commit.

Ooops. It may be too late to rebase, not sure. Ingo, are you sending
that stuff to Linus or are you waiting for me to do so ? In the later
case, I can fold that fix in easily.

Cheers,
Ben.

> Thanks,
> Michal
> 
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index 10bae6e..840026c 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -143,7 +143,7 @@ void __init setup_memory(void)
> 
>          /* reserve allocate blocks */
>          for_each_memblock(reserved, reg) {
> -               pr_debug("reserved %d - 0x%08x-0x%08x\n", i,
> +               pr_debug("reserved - 0x%08x-0x%08x\n",
>                           (u32) reg->base, (u32) reg->size);
>                  reserve_bootmem(reg->base, reg->size, BOOTMEM_DEFAULT);
>          }
> 
>