From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] hwmon: jc42 depends on I2C
Date: Wed, 11 Aug 2010 10:43:31 -0700 [thread overview]
Message-ID: <1281548611.5745.287.camel@groeck-laptop> (raw)
In-Reply-To: <20100811103511.41428e62.randy.dunlap@oracle.com>
On Wed, 2010-08-11 at 13:35 -0400, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> jc42 uses i2c interfaces, so it should depend on I2C.
>
> drivers/hwmon/jc42.c:426: error: implicit declaration of function 'i2c_check_functionality'
> drivers/hwmon/jc42.c:521: error: implicit declaration of function 'i2c_smbus_read_word_data'
> drivers/hwmon/jc42.c:529: error: implicit declaration of function 'i2c_smbus_write_word_data'
> drivers/hwmon/jc42.c:580: error: implicit declaration of function 'i2c_add_driver'
> drivers/hwmon/jc42.c:585: error: implicit declaration of function 'i2c_del_driver'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: lm-sensors@lm-sensors.org
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> drivers/hwmon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20100811.orig/drivers/hwmon/Kconfig
> +++ linux-next-20100811/drivers/hwmon/Kconfig
> @@ -465,6 +465,7 @@ config SENSORS_JZ4740
>
> config SENSORS_JC42
> tristate "JEDEC JC42.4 compliant temperature sensors"
> + depends on I2C
> help
> If you say yes here you get support for Jedec JC42.4 compliant
> temperature sensors. Support will include, but not be limited to,
next prev parent reply other threads:[~2010-08-11 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 4:00 linux-next: Tree for August 11 Stephen Rothwell
2010-08-11 15:51 ` linux-next: Tree for August 11 (hpet) Randy Dunlap
2010-08-11 18:06 ` john stultz
2010-08-11 17:35 ` [PATCH -next] hwmon: jc42 depends on I2C Randy Dunlap
2010-08-11 17:43 ` Guenter Roeck [this message]
2010-08-11 18:15 ` [lm-sensors] " Jean Delvare
2010-08-11 17:36 ` [PATCH -next] firmware: ibft depends on SCSI Randy Dunlap
2010-08-12 14:31 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281548611.5745.287.camel@groeck-laptop \
--to=guenter.roeck@ericsson.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox