linux-next: build failure after merge of the voltage tree

linux-next: build failure after merge of the voltage tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Hi Liam,

After merging the voltage tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/built-in.o: In function `mc13xxx_regulator_is_enabled':
mc13xxx-regulator-core.c:(.text+0x9b01c): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b038): undefined reference to `mc13xxx_reg_read'
mc13xxx-regulator-core.c:(.text+0x9b04a): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_disable':
mc13xxx-regulator-core.c:(.text+0x9b256): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b26f): undefined reference to `mc13xxx_reg_rmw'
mc13xxx-regulator-core.c:(.text+0x9b281): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_enable':
mc13xxx-regulator-core.c:(.text+0x9b323): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b33c): undefined reference to `mc13xxx_reg_rmw'
mc13xxx-regulator-core.c:(.text+0x9b34e): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_get_voltage':
mc13xxx-regulator-core.c:(.text+0x9b3f5): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b40c): undefined reference to `mc13xxx_reg_read'
mc13xxx-regulator-core.c:(.text+0x9b41f): undefined reference to `mc13xxx_unlock'
drivers/built-in.o: In function `mc13xxx_regulator_set_voltage':
mc13xxx-regulator-core.c:(.text+0x9b67f): undefined reference to `mc13xxx_lock'
mc13xxx-regulator-core.c:(.text+0x9b6a4): undefined reference to `mc13xxx_reg_rmw'
mc13xxx-regulator-core.c:(.text+0x9b6b6): undefined reference to `mc13xxx_unlock'

Please build test this stuff ...

I have used the voltage tree from next-20101213 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the voltage tree

[Liam Girdwood]

On Wed, 2010-12-15 at 13:09 +1100, Stephen Rothwell wrote:
> Hi Liam,
> 
> After merging the voltage tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/built-in.o: In function `mc13xxx_regulator_is_enabled':
> mc13xxx-regulator-core.c:(.text+0x9b01c): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b038): undefined reference to `mc13xxx_reg_read'
> mc13xxx-regulator-core.c:(.text+0x9b04a): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_disable':
> mc13xxx-regulator-core.c:(.text+0x9b256): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b26f): undefined reference to `mc13xxx_reg_rmw'
> mc13xxx-regulator-core.c:(.text+0x9b281): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_enable':
> mc13xxx-regulator-core.c:(.text+0x9b323): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b33c): undefined reference to `mc13xxx_reg_rmw'
> mc13xxx-regulator-core.c:(.text+0x9b34e): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_get_voltage':
> mc13xxx-regulator-core.c:(.text+0x9b3f5): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b40c): undefined reference to `mc13xxx_reg_read'
> mc13xxx-regulator-core.c:(.text+0x9b41f): undefined reference to `mc13xxx_unlock'
> drivers/built-in.o: In function `mc13xxx_regulator_set_voltage':
> mc13xxx-regulator-core.c:(.text+0x9b67f): undefined reference to `mc13xxx_lock'
> mc13xxx-regulator-core.c:(.text+0x9b6a4): undefined reference to `mc13xxx_reg_rmw'
> mc13xxx-regulator-core.c:(.text+0x9b6b6): undefined reference to `mc13xxx_unlock'
> 
> Please build test this stuff ...
> 

Sorry, this driver does build as built-in.

Yong, can you send a patch *today* that fixes the modular build for
this.

Thanks

Liam 

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: linux-next: build failure after merge of the voltage tree

[Mark Brown]

On Wed, Dec 15, 2010 at 09:04:44AM +0000, Liam Girdwood wrote:

> Yong, can you send a patch *today* that fixes the modular build for
> this.

Looks like he's not going to get a chance to do that, I'm cooking up
some patches just now which should deal with the issue.

[PATCH] regulator: Allow modular build of mc13xxx-core

[Mark Brown]

Since the MFD core for this device and the regulator drivers for these
devices can be built modular we should also support modular build of
the shared code for the regulator drivers, otherwise we try to link
built in code against modular code with unfortunate results.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/regulator/Kconfig                  |    2 +-
 drivers/regulator/mc13xxx-regulator-core.c |    5 +++++
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 485a9bc..e1d9436 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -187,7 +187,7 @@ config REGULATOR_PCAP
 	 PCAP2 PMIC.
 
 config REGULATOR_MC13XXX_CORE
-	bool
+	tristate
 
 config REGULATOR_MC13783
 	tristate "Support regulators on Freescale MC13783 PMIC"
diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index 448e8f4..da46b3c 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -123,6 +123,7 @@ int mc13xxx_get_best_voltage_index(struct regulator_dev *rdev,
 	}
 	return bestindex;
 }
+EXPORT_SYMBOL_GPL(mc13xxx_get_best_voltage_index);
 
 static int mc13xxx_regulator_set_voltage(struct regulator_dev *rdev, int min_uV,
 		int max_uV, unsigned *selector)
@@ -185,6 +186,7 @@ struct regulator_ops mc13xxx_regulator_ops = {
 	.set_voltage = mc13xxx_regulator_set_voltage,
 	.get_voltage = mc13xxx_regulator_get_voltage,
 };
+EXPORT_SYMBOL_GPL(mc13xxx_regulator_ops);
 
 int mc13xxx_fixed_regulator_set_voltage(struct regulator_dev *rdev, int min_uV,
 	       int max_uV, unsigned *selector)
@@ -202,6 +204,7 @@ int mc13xxx_fixed_regulator_set_voltage(struct regulator_dev *rdev, int min_uV,
 	else
 		return -EINVAL;
 }
+EXPORT_SYMBOL_GPL(mc13xxx_fixed_regulator_set_voltage);
 
 int mc13xxx_fixed_regulator_get_voltage(struct regulator_dev *rdev)
 {
@@ -213,6 +216,7 @@ int mc13xxx_fixed_regulator_get_voltage(struct regulator_dev *rdev)
 
 	return mc13xxx_regulators[id].voltages[0];
 }
+EXPORT_SYMBOL_GPL(mc13xxx_fixed_regulator_get_voltage);
 
 struct regulator_ops mc13xxx_fixed_regulator_ops = {
 	.enable = mc13xxx_regulator_enable,
@@ -222,6 +226,7 @@ struct regulator_ops mc13xxx_fixed_regulator_ops = {
 	.set_voltage = mc13xxx_fixed_regulator_set_voltage,
 	.get_voltage = mc13xxx_fixed_regulator_get_voltage,
 };
+EXPORT_SYMBOL_GPL(mc13xxx_fixed_regulator_ops);
 
 int mc13xxx_sw_regulator_is_enabled(struct regulator_dev *rdev)
 {
-- 
1.7.1

Re: [PATCH] regulator: Allow modular build of mc13xxx-core

[Liam Girdwood]

On Wed, 2010-12-15 at 14:10 +0000, Mark Brown wrote:
> Since the MFD core for this device and the regulator drivers for these
> devices can be built modular we should also support modular build of
> the shared code for the regulator drivers, otherwise we try to link
> built in code against modular code with unfortunate results.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Thanks Mark !

It looks like you sent the wrong patch as I had to also add :-

diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index da46b3c..f53d31b 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -89,6 +89,7 @@ int mc13xxx_regulator_list_voltage(struct regulator_dev *rdev,
 
        return mc13xxx_regulators[id].voltages[selector];
 }
+EXPORT_SYMBOL_GPL(mc13xxx_regulator_list_voltage);
 
 int mc13xxx_get_best_voltage_index(struct regulator_dev *rdev,
                                                int min_uV, int max_uV)
@@ -232,6 +233,7 @@ int mc13xxx_sw_regulator_is_enabled(struct regulator_dev *rdev)
 {
        return 1;
 }
+EXPORT_SYMBOL_GPL(mc13xxx_sw_regulator_is_enabled);
 
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Yong Shen <yong.shen@linaro.org>");

To get it all building.

Now applied and squashed with above.

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: [PATCH] regulator: Allow modular build of mc13xxx-core

[Yong Shen]

Hi there,

My bad. My test did not cover module-build case.
Thanks for fixing this.

Yong

On Thu, Dec 16, 2010 at 5:30 AM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Wed, 2010-12-15 at 14:10 +0000, Mark Brown wrote:
>> Since the MFD core for this device and the regulator drivers for these
>> devices can be built modular we should also support modular build of
>> the shared code for the regulator drivers, otherwise we try to link
>> built in code against modular code with unfortunate results.
>>
>> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> Thanks Mark !
>
> It looks like you sent the wrong patch as I had to also add :-
>
> diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
> index da46b3c..f53d31b 100644
> --- a/drivers/regulator/mc13xxx-regulator-core.c
> +++ b/drivers/regulator/mc13xxx-regulator-core.c
> @@ -89,6 +89,7 @@ int mc13xxx_regulator_list_voltage(struct regulator_dev *rdev,
>
>        return mc13xxx_regulators[id].voltages[selector];
>  }
> +EXPORT_SYMBOL_GPL(mc13xxx_regulator_list_voltage);
>
>  int mc13xxx_get_best_voltage_index(struct regulator_dev *rdev,
>                                                int min_uV, int max_uV)
> @@ -232,6 +233,7 @@ int mc13xxx_sw_regulator_is_enabled(struct regulator_dev *rdev)
>  {
>        return 1;
>  }
> +EXPORT_SYMBOL_GPL(mc13xxx_sw_regulator_is_enabled);
>
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Yong Shen <yong.shen@linaro.org>");
>
> To get it all building.
>
> Now applied and squashed with above.
>
> Liam
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>

linux-next: build failure after merge of the voltage tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

Hi Liam,

After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!

I have used the voltage tree from next-20110509 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the voltage tree

[Liam Girdwood]

On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> Hi Liam,
> 
> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> 
> I have used the voltage tree from next-20110509 for today.

Jorge, could you send a fix for this today.

Thanks

Liam

Re: linux-next: build failure after merge of the voltage tree

[Jorge Eduardo Candelaria]

On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:

> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
>> Hi Liam,
>> 
>> After merging the voltage tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>> 
>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>> 
>> I have used the voltage tree from next-20110509 for today.
> 
> Jorge, could you send a fix for this today.
> 
> Thanks
> 
> Liam
> 

The following patch should solve this:

From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
MFD: Fix TPS65910 build

Support for tps65910 as a module is not available. The driver can
only be compiled as built-in. OTOH, the regulator driver can still
be built as module without breaking the compilation.

Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
---
 drivers/mfd/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 65930a7..c78865e 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -672,8 +672,8 @@ config MFD_OMAP_USB_HOST
 	  OMAP USB Host drivers.
 
 config MFD_TPS65910
-	tristate "TPS65910 Power Management chip"
-	depends on I2C &&  GPIOLIB
+	bool "TPS65910 Power Management chip"
+	depends on I2C && GPIOLIB
 	select MFD_CORE
 	help
 	  if you say yes here you get support for the TPS65910 series of
-- 
1.7.1

Re: linux-next: build failure after merge of the voltage tree

[Liam Girdwood]

On Tue, 2011-05-10 at 12:30 -0500, Jorge Eduardo Candelaria wrote:
> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> 
> > On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >> Hi Liam,
> >> 
> >> After merging the voltage tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >> 
> >> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >> 
> >> I have used the voltage tree from next-20110509 for today.
> > 
> > Jorge, could you send a fix for this today.
> > 
> > Thanks
> > 
> > Liam
> > 
> 
> The following patch should solve this:
> 
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> MFD: Fix TPS65910 build
> 
> Support for tps65910 as a module is not available. The driver can
> only be compiled as built-in. OTOH, the regulator driver can still
> be built as module without breaking the compilation.
> 
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
>  drivers/mfd/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 65930a7..c78865e 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -672,8 +672,8 @@ config MFD_OMAP_USB_HOST
>  	  OMAP USB Host drivers.
>  
>  config MFD_TPS65910
> -	tristate "TPS65910 Power Management chip"
> -	depends on I2C &&  GPIOLIB
> +	bool "TPS65910 Power Management chip"
> +	depends on I2C && GPIOLIB
>  	select MFD_CORE
>  	help
>  	  if you say yes here you get support for the TPS65910 series of


Applied.

Thanks

Liam

Re: linux-next: build failure after merge of the voltage tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]

Hi Jorge,

On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
>
> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> 
> > On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >> Hi Liam,
> >> 
> >> After merging the voltage tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >> 
> >> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >> 
> >> I have used the voltage tree from next-20110509 for today.
> > 
> > Jorge, could you send a fix for this today.
> 
> The following patch should solve this:
> 
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> MFD: Fix TPS65910 build
> 
> Support for tps65910 as a module is not available. The driver can
> only be compiled as built-in. OTOH, the regulator driver can still
> be built as module without breaking the compilation.
> 
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>

Today (even with the above patch included) I got these errors from the
x86_64 allmodconfig build:

tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `tps65910_i2c_read':
tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `tps65910_i2c_init':
tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `tps65910_i2c_exit':
tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'

I have used the voltage tree from next-20110509 again today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the voltage tree

[Jorge Eduardo Candelaria]

On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:

> Hi Jorge,
> 
> On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
>> 
>> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
>> 
>>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
>>>> Hi Liam,
>>>> 
>>>> After merging the voltage tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>> 
>>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
>>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
>>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
>>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
>>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
>>>> 
>>>> I have used the voltage tree from next-20110509 for today.
>>> 
>>> Jorge, could you send a fix for this today.
>> 
>> The following patch should solve this:
>> 
>> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
>> MFD: Fix TPS65910 build
>> 
>> Support for tps65910 as a module is not available. The driver can
>> only be compiled as built-in. OTOH, the regulator driver can still
>> be built as module without breaking the compilation.
>> 
>> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> 
> Today (even with the above patch included) I got these errors from the
> x86_64 allmodconfig build:
> 
> tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> drivers/built-in.o: In function `tps65910_i2c_read':
> tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> drivers/built-in.o: In function `tps65910_i2c_init':
> tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> drivers/built-in.o: In function `tps65910_i2c_exit':
> tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
> 
> I have used the voltage tree from next-20110509 again today.

Following patch should fix the dependency problems. Please review:

From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
[PATCH] MFD: TPS65910: Fix I2C dependency

TPS65910 driver can only be compiled built-in, so the I2C driver
should be as well.

Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
---
 drivers/mfd/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index c78865e..0131d49 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
 
 config MFD_TPS65910
 	bool "TPS65910 Power Management chip"
-	depends on I2C && GPIOLIB
+	depends on I2C=y && GPIOLIB
 	select MFD_CORE
 	help
 	  if you say yes here you get support for the TPS65910 series of
-- 
1.7.1

Re: linux-next: build failure after merge of the voltage tree

[Liam Girdwood]

On Wed, 2011-05-11 at 01:43 -0500, Jorge Eduardo Candelaria wrote:
> On May 10, 2011, at 9:27 PM, Stephen Rothwell wrote:
> 
> > Hi Jorge,
> > 
> > On Tue, 10 May 2011 12:30:36 -0500 Jorge Eduardo Candelaria <jedu@slimlogic.co.uk> wrote:
> >> 
> >> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> >> 
> >>> On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >>>> Hi Liam,
> >>>> 
> >>>> After merging the voltage tree, today's linux-next build (x86_64
> >>>> allmodconfig) failed like this:
> >>>> 
> >>>> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >>>> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >>>> 
> >>>> I have used the voltage tree from next-20110509 for today.
> >>> 
> >>> Jorge, could you send a fix for this today.
> >> 
> >> The following patch should solve this:
> >> 
> >> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> >> MFD: Fix TPS65910 build
> >> 
> >> Support for tps65910 as a module is not available. The driver can
> >> only be compiled as built-in. OTOH, the regulator driver can still
> >> be built as module without breaking the compilation.
> >> 
> >> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> > 
> > Today (even with the above patch included) I got these errors from the
> > x86_64 allmodconfig build:
> > 
> > tps65910.c:(.text+0xf4140): undefined reference to `i2c_master_send'
> > drivers/built-in.o: In function `tps65910_i2c_read':
> > tps65910.c:(.text+0xf41d2): undefined reference to `i2c_transfer'
> > drivers/built-in.o: In function `tps65910_i2c_init':
> > tps65910.c:(.init.text+0xcb83): undefined reference to `i2c_register_driver'
> > drivers/built-in.o: In function `tps65910_i2c_exit':
> > tps65910.c:(.exit.text+0x6e0): undefined reference to `i2c_del_driver'
> > 
> > I have used the voltage tree from next-20110509 again today.
> 
> Following patch should fix the dependency problems. Please review:
> 
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> [PATCH] MFD: TPS65910: Fix I2C dependency
> 
> TPS65910 driver can only be compiled built-in, so the I2C driver
> should be as well.
> 
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
>  drivers/mfd/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c78865e..0131d49 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -673,7 +673,7 @@ config MFD_OMAP_USB_HOST
>  
>  config MFD_TPS65910
>  	bool "TPS65910 Power Management chip"
> -	depends on I2C && GPIOLIB
> +	depends on I2C=y && GPIOLIB
>  	select MFD_CORE
>  	help
>  	  if you say yes here you get support for the TPS65910 series of

Now applied.

Liam

linux-next: build failure after merge of the voltage tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

Hi Liam,

After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/mc13892-regulator.c:21:21: error: mc13xxx.h: No such file or directory
drivers/regulator/mc13892-regulator.c:261: error: array type has incomplete element type
drivers/regulator/mc13892-regulator.c:262: error: implicit declaration of function 'MC13xxx_DEFINE'
drivers/regulator/mc13892-regulator.c:262: error: 'MC13892_' undeclared here (not in a function)

and on and on ....

Caused by commit b0e2417cdbc12b1649245315a607ae8f1072b2bf ("regulator:
support PMIC mc13892").  A file missing from the commit, I assume.

I have used the voltage tree form next-20101213 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the voltage tree

[Yong Shen]

Hi Stephen,

I had already noticed Liam. Mc13892's patch depends on other two
patches which are not applied yet.

Yong

On Tue, Dec 14, 2010 at 12:49 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Liam,
>
> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/regulator/mc13892-regulator.c:21:21: error: mc13xxx.h: No such file or directory
> drivers/regulator/mc13892-regulator.c:261: error: array type has incomplete element type
> drivers/regulator/mc13892-regulator.c:262: error: implicit declaration of function 'MC13xxx_DEFINE'
> drivers/regulator/mc13892-regulator.c:262: error: 'MC13892_' undeclared here (not in a function)
>
> and on and on ....
>
> Caused by commit b0e2417cdbc12b1649245315a607ae8f1072b2bf ("regulator:
> support PMIC mc13892").  A file missing from the commit, I assume.
>
> I have used the voltage tree form next-20101213 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

Re: linux-next: build failure after merge of the voltage tree

[Liam Girdwood]

On Tue, 2010-12-14 at 13:10 +0800, Yong Shen wrote:
> Hi Stephen,
> 
> I had already noticed Liam. Mc13892's patch depends on other two
> patches which are not applied yet.
> 

All applied now. 

Yong, in the future please wait until patches are applied before sending
new dependent patches. This series and the last were quite confusing to
deal with due to the sheer number of similar subject emails. 

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

Re: linux-next: build failure after merge of the voltage tree

[Yong Shen]

Hi Liam,

Thanks for reminding. I will bear that in mind.

Thanks
Yong

On Tue, Dec 14, 2010 at 11:56 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Tue, 2010-12-14 at 13:10 +0800, Yong Shen wrote:
>> Hi Stephen,
>>
>> I had already noticed Liam. Mc13892's patch depends on other two
>> patches which are not applied yet.
>>
>
> All applied now.
>
> Yong, in the future please wait until patches are applied before sending
> new dependent patches. This series and the last were quite confusing to
> deal with due to the sheer number of similar subject emails.
>
> Thanks
>
> Liam
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>

linux-next: build failure after merge of the voltage tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi Liam,

After merging the voltage tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
drivers/regulator/pcap-regulator.c: At top level:
drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type

Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
Report actual configured voltage to set_voltage()").  Please always build
changed files ...

I have used the voltage tree from next-20101110 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the voltage tree

[Mark Brown]

On Thu, Nov 11, 2010 at 11:36:38AM +1100, Stephen Rothwell wrote:

> After merging the voltage tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Oh, a platform where pcap can actually be built!  That's useful, thanks.

> drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
> drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
> drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
> drivers/regulator/pcap-regulator.c: At top level:
> drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type

> Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
> Report actual configured voltage to set_voltage()").  Please always build
> changed files ...

With a lot of the embedded drivers that can be difficult - often there
are dependencies on APIs that are only available on a small set of
platforms (which may not even be documented).  For example, with PCAP
the core driver uses irq_to_gpio() which is not implemented on any of
the platforms I commonly build for.

Re: linux-next: build failure after merge of the voltage tree

[Liam Girdwood]

On Thu, 2010-11-11 at 11:46 +0000, Mark Brown wrote:
> On Thu, Nov 11, 2010 at 11:36:38AM +1100, Stephen Rothwell wrote:
> 
> > After merging the voltage tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> 
> Oh, a platform where pcap can actually be built!  That's useful, thanks.
> 
> > drivers/regulator/pcap-regulator.c:155: error: expected declaration specifiers or '...' before 'unsiged'
> > drivers/regulator/pcap-regulator.c: In function 'pcap_regulator_set_voltage':
> > drivers/regulator/pcap-regulator.c:175: error: 'selector' undeclared (first use in this function)
> > drivers/regulator/pcap-regulator.c: At top level:
> > drivers/regulator/pcap-regulator.c:251: warning: initialization from incompatible pointer type
> 
> > Caused by commit d2f03ebfe8c63d1e3e1ab2352dd32d161546003e ("regulator:
> > Report actual configured voltage to set_voltage()").  Please always build
> > changed files ...
> 
> With a lot of the embedded drivers that can be difficult - often there
> are dependencies on APIs that are only available on a small set of
> platforms (which may not even be documented).  For example, with PCAP
> the core driver uses irq_to_gpio() which is not implemented on any of
> the platforms I commonly build for.
> --

Fix now applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk