linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Samuel Ortiz <sameo@linux.intel.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Arun Murthy <arun.murthy@stericsson.com>
Cc: linux-next@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH] misc: Make AB8500_PWM driver depend on U8500 due to PWM breakage
Date: Mon, 20 Dec 2010 12:28:11 +0000	[thread overview]
Message-ID: <1292848091-29959-1-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20101220192121.47767525.sfr@canb.auug.org.au>

Since we don't have a PWM API every PWM driver ends up exporting its
own version and we need to limit the platforms we try to build them on
in order to avoid multiple definitions. As the AB8500 is normally a
companion chip for the U8500 CPU depend on that architecture.

Previously the driver was relying on the AB8500 core only being built
on U8500 but this did not give us build coverage of any of the other
functions for the device.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

Here's a better way of solving the problem, it means we can build the
MFD and all the other functions on other platforms and still exclude the
problematic PWM driver.

 drivers/misc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 4d073f1..736004d 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -64,7 +64,7 @@ config ATMEL_PWM
 
 config AB8500_PWM
 	bool "AB8500 PWM support"
-	depends on AB8500_CORE
+	depends on AB8500_CORE && ARCH_U8500
 	select HAVE_PWM
 	help
 	  This driver exports functions to enable/disble/config/free Pulse
-- 
1.7.1

  parent reply	other threads:[~2010-12-20 12:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20  8:21 linux-next: build failure after merge of the final tree (mfd tree related) Stephen Rothwell
2010-12-20 10:33 ` Samuel Ortiz
2010-12-20 10:52   ` Mark Brown
2010-12-20 12:18     ` Mark Brown
2010-12-20 12:28 ` Mark Brown [this message]
2010-12-20 13:00   ` [PATCH] misc: Make AB8500_PWM driver depend on U8500 due to PWM breakage Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292848091-29959-1-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=arun.murthy@stericsson.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).