From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: linux-next: Tree for March 1 (staging/winbond) Date: Tue, 01 Mar 2011 22:05:24 +0200 Message-ID: <1299009924.30654.109.camel@jaguar> References: <20110301181119.f1c7a9c3.sfr@canb.auug.org.au> <20110301104924.071044ef.randy.dunlap@oracle.com> <20110301111922.69b0d8c1.randy.dunlap@oracle.com> <20110301113930.69d7d992.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from courier.cs.helsinki.fi ([128.214.9.1]:47354 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757215Ab1CAUF0 (ORCPT ); Tue, 1 Mar 2011 15:05:26 -0500 In-Reply-To: <20110301113930.69d7d992.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , gregkh@suse.de On Tue, 2011-03-01 at 11:39 -0800, Randy Dunlap wrote: > On Tue, 1 Mar 2011 21:35:59 +0200 Pekka Enberg wrote: > > > On Tue, Mar 1, 2011 at 9:19 PM, Randy Dunlap wrote: > > > On Tue, 1 Mar 2011 21:10:23 +0200 Pekka Enberg wrote: > > > > > >> On Tue, Mar 1, 2011 at 8:49 PM, Randy Dunlap wrote: > > >> > On Tue, 1 Mar 2011 18:11:19 +1100 Stephen Rothwell wrote: > > >> > > > >> >> Hi all, > > >> >> > > >> >> Changes since 20110228: > > >> > > > >> > > > >> > commit ddee7e28e7d5e4ba2b8537c6a59b035745c250bb > > >> > Author: Pekka Enberg > > >> > Date: Sun Nov 28 23:00:01 2010 +0200 > > >> > Staging: w35und: Remove empty sysdef.h header > > >> > > > >> > > > >> > This header should not have been empty, since in > > >> > > > >> > commit 412dc7f368bf10a8049a8a4c41abbfd0108742e7 > > >> > Author: Randy Dunlap > > >> > Date: Fri Nov 19 09:30:18 2010 -0800 > > >> > staging: fix winbond build, needs delay.h > > >> > > > >> > I added delay.h to it. And now we have the same build > > >> > errors that I fixed last November: > > >> > > > >> > drivers/staging/winbond/phy_calibration.c:986: error: implicit declaration of function 'msleep' > > >> > drivers/staging/winbond/phy_calibration.c:1555: error: implicit declaration of function 'udelay' > > >> > drivers/staging/winbond/reg.c:893: error: implicit declaration of function 'msleep' > > >> > drivers/staging/winbond/reg.c:1169: error: implicit declaration of function 'udelay' > > >> > > >> Strange. I didn't see the problem. We should add delay.h to > > >> phy_calibration.c and reg.c instead. Care to make a patch? > > >> -- > > > > > > No thanks, I'll let the staging people do that. > > > > Hmm, commit cecf826df8648c843ea8db63b1f82c154a74db36 ("staging: > > winbond: needs for msleep and friends") should fix it. > > Isn't it in linux-next yet? > > I'll have to let GregKH answer that. > > Where is the commit ID from? It's from staging tree staging-next branch. Pekka