From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alexander van Heukelum" Subject: Re: linux-next: Tree for March 8 (BROKEN: arch/x86/kernel/entry_32.S? Debian's binutils/as?) Date: Tue, 08 Mar 2011 21:59:11 +0100 Message-ID: <1299617951.5031.1427586241@webmail.messagingengine.com> References: <1299605269.29313.1427511237@webmail.messagingengine.com><1299615939.25628.1427572905@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from out5.smtp.messagingengine.com ([66.111.4.29]:55414 "EHLO out5.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754753Ab1CHU7M convert rfc822-to-8bit (ORCPT ); Tue, 8 Mar 2011 15:59:12 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: "H.J. Lu" , sedat.dilek@gmail.com Cc: Sedat Dilek , Ingo Molnar , linux-next , psomas@cslab.ece.ntua.gr, Jan Beulich , "H. Peter Anvin" On Tue, 08 Mar 2011 12:45 -0800, "H.J. Lu" wrote: > On Tue, Mar 8, 2011 at 12:33 PM, Sedat Dilek > wrote: > > On Tue, Mar 8, 2011 at 9:25 PM, Alexander van Heukelum > > wrote: > >> On Tue, 08 Mar 2011 18:53 +0100, "Sedat Dilek" wrote: > >>> On Tue, Mar 8, 2011 at 6:27 PM, Alexander van Heukelum > >>> wrote: > >>> > On Tue, 08 Mar 2011 16:42 +0100, "Sedat Dilek" wrote: > >>> >> On 3/8/11, Sedat Dilek wrote: > >>> >> > On 3/8/11, H.J. Lu wrote: > >>> >> >> On Tue, Mar 8, 2011 at 2:44 AM, Sedat Dilek > >>> >> >> wrote: > >>> >> >>> Hi, > >>> >> >>> > >>> >> >>> my build of linux-next (next-20110308, the same with the o= ne from > >>> >> >>> yesterday) is broken. > >>> >> >>> (I translated the German output.) > >>> >> >>> > >>> >> >>> [ build.log ] > >>> >> >>> =C2=A0AS =C2=A0 =C2=A0 =C2=A0arch/x86/kernel/entry_32.o > >>> >> >>> /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/sourc= e_i386_none/arch/x86/kernel/entry_32.S: > >>> >> >>> Assembler messages: > >>> >> >>> /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/sourc= e_i386_none/arch/x86/kernel/entry_32.S:1421: > >>> >> >>> Error: .size expression does not evaluate to a constant > >>> >> >>> make[6]: *** [arch/x86/kernel/entry_32.o] Fehler 1 (Error = 1) > >>> >> >>> make[5]: *** [arch/x86/kernel] Fehler 2 (Error 2) > >>> >> >>> make[4]: *** [arch/x86] Fehler 2 (Error 2) > >>> >> >>> make[4]: *** Warte auf noch nicht beendete Prozesse... (Wa= iting for > >>> >> >>> unfinished jobs...) > >>> >> >>> > >>> >> >> > >>> >> >> This is a kernel bug. =C2=A0Please use the latest binutils = from CVS. > >>> >> >> It will tell you which symbol causes this. > >>> >> >> > >>> >> >> > >>> >> >> -- > >>> >> >> H.J. > >>> >> >> > >>> >> > > >>> >> > Yeah, I have cherry-picked these two upstream commits before= you have > >>> >> > mentionned it... > >>> >> > > >>> >> > 0001-Mention-symbol-name-in-non-constant-.size-expression.pa= tch > >>> >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0(Cherry-picked from commit b9521f= c0be7945fc842ce1197e241a023378125d) > >>> >> > 0002-Revert-the-last-change-on-gas-elf-bad-size.err.patch > >>> >> > =C2=A0 =C2=A0 =C2=A0 =C2=A0(Cherry-picked from commit cbd141= bb69f791de7ea1581abe7afb34f0c61288) > >>> >> > > >>> >> > ... and have built with them a new binutils Debian package. > >>> >> > > >>> >> > The error looks now like this (sorry for the German output): > >>> >> > ... > >>> >> > =C2=A0 AS =C2=A0 =C2=A0 =C2=A0arch/x86/kernel/entry_32.o > >>> >> > /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_= i386_none/arch/x86/kernel/entry_32.S: > >>> >> > Assembler messages: > >>> >> > /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_= i386_none/arch/x86/kernel/entry_32.S:1421: > >>> >> > Error: .size expression with symbol `apf_page_fault' does no= t evaluate > >>> >> > to a constant > >>> >> > make[6]: *** [arch/x86/kernel/entry_32.o] Fehler 1 > >>> >> > make[5]: *** [arch/x86/kernel] Fehler 2 > >>> >> > make[5]: *** Warte auf noch nicht beendete Prozesse... > >>> >> > > >>> >> > Anyway, before more riddling around it would be very helpful= to have a > >>> >> > clear pointer if there is a fix around... That building, tes= ting and > >>> >> > installing took me now several hours. > >>> >> > And... yeah, backports to 2.21-branch appreciated. > >>> >> > > >>> >> > - Sedat - > >>> >> > > >>> >> > >>> >> After a quick look into the source, it seems attached patch fi= xes the > >>> >> issue. > >>> >> Is that OK? > >>> > > >>> > Hi Sedat, > >>> > > >>> > The patch ( https://lkml.org/lkml/2011/3/8/203 ) is ok, feel fr= ee to add > >>> > Acked-by: Alexander van Heukelum > >>> > > >>> > Better description might be something like: > >>> > > >>> > i386: Fix mismatched ENTRY/END pair. > >>> > > >>> > Under CONFIG_KVM_GUEST=3Dy, the following part of entry_32.S ca= uses a compile failure. > >>> > > >>> > 1409 #ifdef CONFIG_KVM_GUEST > >>> > 1410 ENTRY(async_page_fault) > >>> > 1411 =C2=A0 =C2=A0 =C2=A0 =C2=A0 RING0_EC_FRAME > >>> > 1412 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pushl $do_async_page_fault > >>> > 1413 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CFI_ADJUST_CFA_OFFSET 4 > >>> > 1414 =C2=A0 =C2=A0 =C2=A0 =C2=A0 jmp error_code > >>> > 1415 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CFI_ENDPROC > >>> > 1416 END(apf_page_fault) > >>> > 1417 #endif > >>> > > >>> > Replace apf_page_fault with async_page_fault, as intended. > >>> > > >>> > Greetings, > >>> > =C2=A0 =C2=A0Alexander > >>> > > >>> >> - Sedat - > >>> >> > >>> >> Email had 1 attachment: > >>> >> + 0001-x86-Fix-build-failure-with-binutils-as-from-upstream.pa= tch > >>> >> =C2=A0 1k (text/x-patch) > >>> > > >>> > >>> As I said, quick view on the code, quick fix :-). > >>> > >>> Your description is definitive more meaningful. > >>> I can refresh my patch and add your ACK. > >>> > >>> Anyway, I continued after dinner and with the above patch I ran i= nto > >>> the next problem: > >>> [ build.log ] > >>> ... > >>> =C2=A0 AS =C2=A0 =C2=A0 =C2=A0arch/x86/kernel/acpi/wakeup_rm.o > >>> /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_i386_= none/arch/x86/kernel/acpi/wakeup_rm.S: > >>> Assembler messages: > >>> /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_i386_= none/arch/x86/kernel/acpi/wakeup_rm.S:12: > >>> Error: .size expression with symbol `wakeup_code_start' does not > >>> evaluate to a constant > >> > >> No idea what's wrong there. But my version of wakeup_rm.S has only= 10 lines... > >> > >> =C2=A0 =C2=A0 1 =C2=A0/* > >> =C2=A0 =C2=A0 2 =C2=A0 * Wrapper script for the realmode binary as= a transport object > >> =C2=A0 =C2=A0 3 =C2=A0 * before copying to low memory. > >> =C2=A0 =C2=A0 4 =C2=A0 */ > >> =C2=A0 =C2=A0 5 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.section ".rodat= a","a" > >> =C2=A0 =C2=A0 6 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.globl =C2=A0wak= eup_code_start, wakeup_code_end > >> =C2=A0 =C2=A0 7 =C2=A0wakeup_code_start: > >> =C2=A0 =C2=A0 8 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.incbin "arch/x8= 6/kernel/acpi/realmode/wakeup.bin" > >> =C2=A0 =C2=A0 9 =C2=A0wakeup_code_end: > >> =C2=A0 =C2=A010 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0.size =C2=A0 wak= eup_code_start, .-wakeup_code_start > >> > >> And it compiles just fine. > >> The fix for entry_32.S is valid, though, and necessary for mainlin= e. > >> > >> Greetings, > >> =C2=A0 =C2=A0Alexander > >> > >>> I am unsure how to fix that and open for feedback. > >>> > >>> - Sedat - > >>> > >> > > > > The file in linux-next (next-20110308) looks different (the above c= ode > > looks more logical to me) > > > > [ arch/x86/kernel/acpi/wakeup_rm.S ] > > > > /* > > =C2=A0* Wrapper script for the realmode binary as a transport objec= t > > =C2=A0* before copying to low memory. > > =C2=A0*/ > > #include > > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0.section ".x86_trampoline","a" > > =C2=A0 =C2=A0 =C2=A0 =C2=A0.balign PAGE_SIZE > > =C2=A0 =C2=A0 =C2=A0 =C2=A0.globl =C2=A0acpi_wakeup_code > > acpi_wakeup_code: > > =C2=A0 =C2=A0 =C2=A0 =C2=A0.incbin "arch/x86/kernel/acpi/realmode/w= akeup.bin" > > =C2=A0 =C2=A0 =C2=A0 =C2=A0.size =C2=A0 wakeup_code_start, .-wakeup= _code_start >=20 > Those are simply wrong. 2.6.38-rc8 is OK. Right :) That last line should be: .size acpi_wakeup_code, .-acpi_wakeup_code Sedat, care to make that patch, test-compile, and send to Ingo for -tip= ? > --=20 > H.J. >=20