From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Hellstrom <daniel@gaisler.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: linux-next: manual merge of the tip tree with the sparc tree
Date: Thu, 19 May 2011 17:35:06 +0200 [thread overview]
Message-ID: <1305819306.2466.7228.camel@twins> (raw)
In-Reply-To: <4DD51D37.3010907@gaisler.com>
On Thu, 2011-05-19 at 15:37 +0200, Daniel Hellstrom wrote:
> diff --git a/arch/sparc/kernel/smp_32.c b/arch/sparc/kernel/smp_32.c
> index 41102c5..d5b3958 100644
> --- a/arch/sparc/kernel/smp_32.c
> +++ b/arch/sparc/kernel/smp_32.c
> @@ -156,11 +156,11 @@ void arch_send_call_function_ipi_mask(const struct
> cpumask *mask)
>
> void smp_resched_interrupt(void)
> {
> + irq_enter();
> + scheduler_ipi();
> local_cpu_data().irq_resched_count++;
> - /*
> - * do nothing, since it all was about calling re-schedule
> - * routine called by interrupt return code.
> - */
> + irq_exit();
> + /* re-schedule routine called by interrupt return code. */
> }
That doesn't look like an IPI, that looks like its calls the function on
the local cpu, which is completely pointless.
next prev parent reply other threads:[~2011-05-19 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 3:14 linux-next: manual merge of the tip tree with the sparc tree Stephen Rothwell
2011-05-19 13:37 ` Daniel Hellstrom
2011-05-19 15:35 ` Peter Zijlstra [this message]
2011-05-20 6:07 ` Daniel Hellstrom
2011-05-20 8:11 ` Peter Zijlstra
2011-05-20 12:48 ` Daniel Hellstrom
2011-05-20 13:24 ` Peter Zijlstra
2011-05-20 2:18 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2015-05-28 6:38 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305819306.2466.7228.camel@twins \
--to=peterz@infradead.org \
--cc=daniel@gaisler.com \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox