From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH 2/2] mtd/ofpart: add ofoldpart alias Date: Mon, 27 Jun 2011 09:03:26 +0300 Message-ID: <1309154611.23597.18.camel@sauron> References: <1309122180-12838-1-git-send-email-dbaryshkov@gmail.com> <1309122180-12838-3-git-send-email-dbaryshkov@gmail.com> <1309153545.23597.13.camel@sauron> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Dmitry Eremin-Solenikov Cc: Randy Dunlap , Stephen Rothwell , linux-kernel@vger.kernel.org, Grant Likely , linux-next@vger.kernel.org, linux-mtd@lists.infradead.org, David Woodhouse List-Id: linux-next.vger.kernel.org On Mon, 2011-06-27 at 09:51 +0400, Dmitry Eremin-Solenikov wrote: > On 6/27/11, Artem Bityutskiy wrote: > > On Mon, 2011-06-27 at 01:03 +0400, Dmitry Eremin-Solenikov wrote: > >> ofpart.ko also provides ofoldpart MTD parser. Add respective > >> MODULE_ALIAS("ofoldpart"); declaration. > >> > > > > Why we need the alias? > > Please check the parse_mtd_partitions code. If requested parser > isn't registered, it tries to load corresponding module. So, this alias > is necessary in the semi-bogus case when one will have the list > of parsers containing ofoldpart, but not ofpart partition parser. Fair enough, but would you please prepend MODULE_ALIAS with a comment like this which explains why we need the alias? -- Best Regards, Artem Bityutskiy ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/