From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: Re: linux-next: Tree for Oct 25 (target) Date: Wed, 26 Oct 2011 13:42:12 -0700 Message-ID: <1319661732.21607.14.camel@haakon2.linux-iscsi.org> References: <20111025203628.40a1b8a475e32053aa34dabe@canb.auug.org.au> <4EA853F2.4040503@xenotime.net> <1319658791.21607.5.camel@haakon2.linux-iscsi.org> <20111027074002.8cd56b32b3f1200070abc4d9@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111027074002.8cd56b32b3f1200070abc4d9@canb.auug.org.au> Sender: target-devel-owner@vger.kernel.org To: Stephen Rothwell Cc: Randy Dunlap , linux-next@vger.kernel.org, LKML , Linus , target-devel@vger.kernel.org, Paul Gortmaker List-Id: linux-next.vger.kernel.org On Thu, 2011-10-27 at 07:40 +1100, Stephen Rothwell wrote: > On Wed, 26 Oct 2011 12:53:11 -0700 "Nicholas A. Bellinger" wrote: > > > > On Wed, 2011-10-26 at 11:39 -0700, Randy Dunlap wrote: > > > On 10/25/11 02:36, Stephen Rothwell wrote: > > > > Hi all, > > > > > > target_core_cdb.c needs to include : > > > > > > drivers/target/target_core_cdb.c:1316:1: warning: data definition has no type or storage class [enabled by default] > > > drivers/target/target_core_cdb.c:1316:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > > > drivers/target/target_core_cdb.c:1316:1: warning: parameter names (without types) in function declaration [enabled by default] > > > > > > > > > > This one had been addressed in target-pending.git/for-next with a > > module.h include for target_core_cdb.c, but I'll change this now to use > > the proper export.h. > > Except that export.h does not exist in Linus' tree yet. Just leave the > module.h there and it will be changed sometime later. > Got it. Thank you for the heads up Stephen. --nan