From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: RE: [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions Date: Thu, 05 Jan 2012 08:30:45 -0800 Message-ID: <1325781045.22154.15.camel@joe2Laptop> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:38599 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932728Ab2AEQas (ORCPT ); Thu, 5 Jan 2012 11:30:48 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: David Laight Cc: Kalle Valo , linville@tuxdriver.com, sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, ath6kl-devel@qualcomm.com, davem@davemloft.net On Thu, 2012-01-05 at 10:41 +0000, David Laight wrote: > > > + va_start(args, fmt); > > > + ath6kl_printk(KERN_DEBUG, fmt, &args); > > Passing a va_list as an argument? > > I believe this doesn't work. > > I think you'll need to add and use: > Passing a va_list certainly does work - vprintf() etc. > What is problematical is taking the address of a va_list. Nope. This referred to this specific instance. Taking the address of a va_list works fine. Look at the provide example.