From: Artem Bityutskiy <dedekind1@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: linux-next: build failure after merge of the l2-mtd tree
Date: Mon, 06 Feb 2012 11:14:14 +0200 [thread overview]
Message-ID: <1328519654.22240.31.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120206120706.cf5d951972d22eb7fa134fbd@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Mon, 2012-02-06 at 12:07 +1100, Stephen Rothwell wrote:
> Hi Artem,
>
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/mtd/devices/pmc551.c:191:12: error: conflicting types for 'pmc551_unpoint'
> include/linux/mtd/pmc551.h:37:13: note: previous declaration of 'pmc551_unpoint' was here
> drivers/mtd/devices/pmc551.c: In function 'pmc551_unpoint':
> drivers/mtd/devices/pmc551.c:196:1: warning: no return statement in function returning non-void [-Wreturn-type]
>
> Caused by commit 753c57f84b57 ("mtd: return error code from
> mtd_unpoint"). [Mind you, I don't understand why those static functions
> would be declared in a header file ...]
Thanks, fixed. I am doing rather massive MTD API cleaning, so new small
issues are possible.
WRT the header file - I think it should not be in 'inlude/linux' at all
- I'll try to cook a patch to kick it out of there, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-06 9:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 1:07 linux-next: build failure after merge of the l2-mtd tree Stephen Rothwell
2012-02-06 9:14 ` Artem Bityutskiy [this message]
2012-02-06 21:10 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2012-02-07 2:58 Stephen Rothwell
2012-02-07 8:02 ` Artem Bityutskiy
2012-10-12 0:14 Stephen Rothwell
2012-10-12 4:51 ` Dinh Nguyen
2012-10-18 0:28 ` Stephen Rothwell
2012-10-18 9:26 ` Artem Bityutskiy
2014-05-22 5:30 Stephen Rothwell
2014-05-26 17:42 ` Brian Norris
2014-05-26 23:59 ` Stephen Rothwell
2014-05-27 10:40 ` Artem Bityutskiy
2014-05-27 22:49 ` Stephen Rothwell
2015-09-30 5:16 Stephen Rothwell
2015-12-21 5:47 Stephen Rothwell
2016-07-19 0:59 Stephen Rothwell
2016-07-19 1:20 ` Brian Norris
2016-07-19 1:46 ` Stephen Rothwell
2017-02-09 1:08 Stephen Rothwell
2017-02-09 1:59 ` Brian Norris
2017-08-28 2:19 Stephen Rothwell
2017-08-28 22:06 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328519654.22240.31.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).