From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH - linux-next] ARM: ptrace: Fix audit caused compile error Date: Tue, 21 Feb 2012 08:49:22 -0500 Message-ID: <1329832162.2337.44.camel@localhost> References: <1329825855-11902-1-git-send-email-peter.ujfalusi@ti.com> <20120221131616.GI19696@mudshark.cambridge.arm.com> <20120221133044.GN22562@n2100.arm.linux.org.uk> <1329831350.2337.43.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx1.redhat.com ([209.132.183.28]:23503 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752921Ab2BUNt7 (ORCPT ); Tue, 21 Feb 2012 08:49:59 -0500 In-Reply-To: <1329831350.2337.43.camel@localhost> Sender: linux-next-owner@vger.kernel.org List-ID: To: Russell King - ARM Linux Cc: Stephen Rothwell , Will Deacon , Peter Ujfalusi , "linux-next@vger.kernel.org" , "linux-audit@redhat.com" , "linux-arm-kernel@lists.infradead.org" On Tue, 2012-02-21 at 08:35 -0500, Eric Paris wrote: > On Tue, 2012-02-21 at 13:30 +0000, Russell King - ARM Linux wrote: > > On Tue, Feb 21, 2012 at 01:16:17PM +0000, Will Deacon wrote: > > > On Tue, Feb 21, 2012 at 12:04:15PM +0000, Peter Ujfalusi wrote: > > > > While trying to compile the kernel for ARM (omap2plus_defconfig= ) the kernel > > > > build fails with: > > > >=20 > > > > arch/arm/kernel/ptrace.c: In function =E2=80=98syscall_trace=E2= =80=99: > > > > arch/arm/kernel/ptrace.c:920:3: error: implicit declaration of = function =E2=80=98audit_syscall_exit=E2=80=99 > > > > arch/arm/kernel/ptrace.c:922:3: error: implicit declaration of = function =E2=80=98audit_syscall_entry=E2=80=99 > > > > arch/arm/kernel/ptrace.c:922:23: error: =E2=80=98AUDIT_ARCH_ARM= EB=E2=80=99 undeclared (first use in this function) > > > > arch/arm/kernel/ptrace.c:922:23: note: each undeclared identifi= er is reported only once for each function it appears in > > > > make[1]: *** [arch/arm/kernel/ptrace.o] Error 1 > > > >=20 > > > > The issue created by commit: > > > > 29ef73b7 Kernel: Audit Support For The ARM Platform > > > >=20 > > > > We need to include the linux/audit.h header to the arch/arm/ker= nel/ptrace.c > > > > file to be able to compile the kernel. > > >=20 > > > This was already reported and I think Russell was going to revert= the > > > offending commit, since it needed some rework to handle little-en= dian > > > configurations. > > >=20 > > > I can't see the revert in any of the trees I'm tracking though... > >=20 > > I never pushed that out because I thought someone was going to fix = it. > > Were any patches produced to fix it? I can't see anything in the p= atch > > system and I couldn't see anything on the list. > >=20 > > It seems the previous thread about it just died. Oh well, I guess = a > > revert is what's required after all. >=20 > http://marc.info/?l=3Dlinux-arm-kernel&m=3D132928424120369&w=3D2 >=20 > ??? You probably meant the arch endian bug. I wrote a patch for it, but guess i never sent it. It was just sitting on my audit arm branch. So I just sent that one as well. Thanks Russell! -Eric