[PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

[PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

[Paul Gortmaker]

Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)

    "ARM: kirkwood: mv_cesa devicetree bindings"

fails to compile as follows:

 CC      drivers/crypto/mv_cesa.o
 drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr'
 drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function)
 drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
 drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table')

because it is missing the linux/of.h header file.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
index b7a3d48..093e214 100644
--- a/drivers/crypto/mv_cesa.c
+++ b/drivers/crypto/mv_cesa.c
@@ -10,6 +10,7 @@
 #include <crypto/algapi.h>
 #include <linux/crypto.h>
 #include <linux/interrupt.h>
+#include <linux/of.h>
 #include <linux/io.h>
 #include <linux/kthread.h>
 #include <linux/platform_device.h>
-- 
1.7.9.1

Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

[Jason Cooper]

On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote:
> Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)
> 
>     "ARM: kirkwood: mv_cesa devicetree bindings"
> 
> fails to compile as follows:
> 
>  CC      drivers/crypto/mv_cesa.o
>  drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr'
>  drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function)
>  drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
>  drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table')
> 
> because it is missing the linux/of.h header file.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Paul,

Thanks for the patch.  Unfortunately, I'm not learning fast enough.  ;-)
This series has been in a lot of flux lately, as you've experienced.

The good news is, after talking with Olaf and Arnd, I think I have a
good workflow figured out.  Hopefully, failures like this won't happen
in the future.

As an fyi, I'm probably going to take kirkwood_dt_staging down (or, label
it broken ;-) )  I intended it as a publicly viewable branch of "what's
coming down the pipe", but it's not working out the way I intended.

As for mv_cesa, it's next on my list.  As soon as I figure out the irq
stuff.

Thanks for testing.

Jason.

> 
> diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
> index b7a3d48..093e214 100644
> --- a/drivers/crypto/mv_cesa.c
> +++ b/drivers/crypto/mv_cesa.c
> @@ -10,6 +10,7 @@
>  #include <crypto/algapi.h>
>  #include <linux/crypto.h>
>  #include <linux/interrupt.h>
> +#include <linux/of.h>
>  #include <linux/io.h>
>  #include <linux/kthread.h>
>  #include <linux/platform_device.h>
> -- 
> 1.7.9.1
> 

Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

[Paul Gortmaker]

On Sat, Mar 10, 2012 at 8:42 PM, Jason Cooper <jason@lakedaemon.net> wrote:
> On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote:
>> Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)
>>
>>     "ARM: kirkwood: mv_cesa devicetree bindings"
>>
>> fails to compile as follows:
>>
>>  CC      drivers/crypto/mv_cesa.o
>>  drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr'
>>  drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function)
>>  drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
>>  drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table')
>>
>> because it is missing the linux/of.h header file.
>>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Paul,
>
> Thanks for the patch.  Unfortunately, I'm not learning fast enough.  ;-)
> This series has been in a lot of flux lately, as you've experienced.
>
> The good news is, after talking with Olaf and Arnd, I think I have a
> good workflow figured out.  Hopefully, failures like this won't happen
> in the future.

Sounds good -- don't be too hard on yourself wrt. a minor breakage.
Feel free to just squish the above patch into whatever updates you
have going.  I don't see it needing to exist as a standalone commit.

THanks,
Paul.
--

>
> As an fyi, I'm probably going to take kirkwood_dt_staging down (or, label
> it broken ;-) )  I intended it as a publicly viewable branch of "what's
> coming down the pipe", but it's not working out the way I intended.
>
> As for mv_cesa, it's next on my list.  As soon as I figure out the irq
> stuff.
>
> Thanks for testing.
>
> Jason.
>
>>
>> diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c
>> index b7a3d48..093e214 100644
>> --- a/drivers/crypto/mv_cesa.c
>> +++ b/drivers/crypto/mv_cesa.c
>> @@ -10,6 +10,7 @@
>>  #include <crypto/algapi.h>
>>  #include <linux/crypto.h>
>>  #include <linux/interrupt.h>
>> +#include <linux/of.h>
>>  #include <linux/io.h>
>>  #include <linux/kthread.h>
>>  #include <linux/platform_device.h>
>> --
>> 1.7.9.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

[Jason]

On Sun, Mar 11, 2012 at 12:17:29PM -0400, Paul Gortmaker wrote:
> On Sat, Mar 10, 2012 at 8:42 PM, Jason Cooper <jason@lakedaemon.net> wrote:
> > On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote:
> >> Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next)
> >>
> >>     "ARM: kirkwood: mv_cesa devicetree bindings"
> >>
> >> fails to compile as follows:
> >>
> >>  CC      drivers/crypto/mv_cesa.o
> >>  drivers/crypto/mv_cesa.c:1139: error: implicit declaration of function 'of_match_ptr'
> >>  drivers/crypto/mv_cesa.c:1139: error: 'mv_cesa_dt_ids' undeclared here (not in a function)
> >>  drivers/crypto/mv_cesa.c:1139: error: initializer element is not constant
> >>  drivers/crypto/mv_cesa.c:1139: error: (near initialization for 'marvell_crypto.driver.of_match_table')
> >>
> >> because it is missing the linux/of.h header file.
> >>
> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> >
> > Paul,
> >
> > Thanks for the patch.  Unfortunately, I'm not learning fast enough.  ;-)
> > This series has been in a lot of flux lately, as you've experienced.
> >
> > The good news is, after talking with Olaf and Arnd, I think I have a
> > good workflow figured out.  Hopefully, failures like this won't happen
> > in the future.
> 
> Sounds good -- don't be too hard on yourself wrt. a minor breakage.
> Feel free to just squish the above patch into whatever updates you
> have going.  I don't see it needing to exist as a standalone commit.

Thanks, it's definitely better that it be squashed into the existing
commit.  I wouldn't want a bisect to land in between it down the road.

thx,

Jason.