From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sage Ahn <syahn@gctsemi.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] staging: gdm72xx: WIMAX_GDM72XX_USB_PM should depend on USB_SUSPEND
Date: Wed, 16 May 2012 21:47:40 +0200 [thread overview]
Message-ID: <1337197660-7852-1-git-send-email-geert@linux-m68k.org> (raw)
Use Kconfig logic instead of a rude #error in the driver source,
which breaks m68k-allmodconfig.
Also remove the "default n", as that's the default.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/6335693/
drivers/staging/gdm72xx/Kconfig | 2 +-
drivers/staging/gdm72xx/gdm_usb.c | 6 ------
2 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index 5c37cba..fc58427 100644
--- a/drivers/staging/gdm72xx/Kconfig
+++ b/drivers/staging/gdm72xx/Kconfig
@@ -38,7 +38,7 @@ if WIMAX_GDM72XX_USB
config WIMAX_GDM72XX_USB_PM
bool "Enable power managerment support"
- default n
+ depends on USB_SUSPEND
endif # WIMAX_GDM72XX_USB
diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c
index 004786b..f60e890 100644
--- a/drivers/staging/gdm72xx/gdm_usb.c
+++ b/drivers/staging/gdm72xx/gdm_usb.c
@@ -17,12 +17,6 @@
#include <linux/usb.h>
#include <asm/byteorder.h>
-#ifdef CONFIG_WIMAX_GDM72XX_USB_PM
-#ifndef CONFIG_USB_SUSPEND
-#error "USB host doesn't support USB Selective Suspend."
-#endif
-#endif
-
#include "gdm_usb.h"
#include "gdm_wimax.h"
#include "usb_boot.h"
--
1.7.0.4
next reply other threads:[~2012-05-16 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 19:47 Geert Uytterhoeven [this message]
2012-05-16 20:31 ` [PATCH] staging: gdm72xx: WIMAX_GDM72XX_USB_PM should depend on USB_SUSPEND Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337197660-7852-1-git-send-email-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=syahn@gctsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox