From: Alex Williamson <alex.williamson@redhat.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-next@vger.kernel.org
Subject: Re: VFIO compile failure on i386 allmodconfig in linux-next
Date: Thu, 28 Jun 2012 16:25:47 -0600 [thread overview]
Message-ID: <1340922347.3179.60.camel@ul30vt> (raw)
In-Reply-To: <20120628175712.GA20250@windriver.com>
On Thu, 2012-06-28 at 13:57 -0400, Paul Gortmaker wrote:
> Hi Alex,
>
> Just a heads up that the i386 allmodconfig failed on VFIO, in case
> you didn't see it.
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/6603285/
>
> arch/x86/include/asm/uaccess_32.h:211:26: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct
> make[4]: *** [drivers/vfio/pci/vfio_pci_config.o] Error 1
Thank you for the report. This looks bogus to me, it's complaining
about a copy_from_user into an __le32 because it can't determine the
number of bytes to be copied. That number is a parameter to the
function, but the function is static and only called with values of 1, 2
or 4. I've added a test that seems to make the compiler happy, so this
will be fixed in tomorrow's tree. Thanks!
Alex
prev parent reply other threads:[~2012-06-28 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 17:57 VFIO compile failure on i386 allmodconfig in linux-next Paul Gortmaker
2012-06-28 22:25 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340922347.3179.60.camel@ul30vt \
--to=alex.williamson@redhat.com \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox