linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* VFIO compile failure on i386 allmodconfig in linux-next
@ 2012-06-28 17:57 Paul Gortmaker
  2012-06-28 22:25 ` Alex Williamson
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2012-06-28 17:57 UTC (permalink / raw)
  To: alex.williamson; +Cc: linux-next

Hi Alex,

Just a heads up that the i386 allmodconfig failed on VFIO, in case
you didn't see it.

http://kisskb.ellerman.id.au/kisskb/buildresult/6603285/

arch/x86/include/asm/uaccess_32.h:211:26: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct
make[4]: *** [drivers/vfio/pci/vfio_pci_config.o] Error 1

Paul.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: VFIO compile failure on i386 allmodconfig in linux-next
  2012-06-28 17:57 VFIO compile failure on i386 allmodconfig in linux-next Paul Gortmaker
@ 2012-06-28 22:25 ` Alex Williamson
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2012-06-28 22:25 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: linux-next

On Thu, 2012-06-28 at 13:57 -0400, Paul Gortmaker wrote:
> Hi Alex,
> 
> Just a heads up that the i386 allmodconfig failed on VFIO, in case
> you didn't see it.
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/6603285/
> 
> arch/x86/include/asm/uaccess_32.h:211:26: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct
> make[4]: *** [drivers/vfio/pci/vfio_pci_config.o] Error 1

Thank you for the report.  This looks bogus to me, it's complaining
about a copy_from_user into an __le32 because it can't determine the
number of bytes to be copied.  That number is a parameter to the
function, but the function is static and only called with values of 1, 2
or 4.  I've added a test that seems to make the compiler happy, so this
will be fixed in tomorrow's tree.  Thanks!

Alex

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-28 22:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-28 17:57 VFIO compile failure on i386 allmodconfig in linux-next Paul Gortmaker
2012-06-28 22:25 ` Alex Williamson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).