* [PATCH -next] staging: dgrp: Add missing #include <linux/uaccess.h>
@ 2012-09-27 18:38 Geert Uytterhoeven
2012-10-11 12:40 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-09-27 18:38 UTC (permalink / raw)
To: Bill Pemberton, Greg Kroah-Hartman
Cc: devel, linux-kernel, linux-next, Geert Uytterhoeven
On m68k:
drivers/staging/dgrp/dgrp_mon_ops.c: In function ‘dgrp_mon_read’:
drivers/staging/dgrp/dgrp_mon_ops.c:304: error: implicit declaration of function ‘copy_to_user’
drivers/staging/dgrp/dgrp_specproc.c: In function ‘config_proc_write’:
drivers/staging/dgrp/dgrp_specproc.c:470: error: implicit declaration of function ‘copy_from_user’
drivers/staging/dgrp/dgrp_tty.c: In function ‘drp_wmove’:
drivers/staging/dgrp/dgrp_tty.c:1284: error: implicit declaration of function ‘copy_from_user’
drivers/staging/dgrp/dgrp_tty.c: In function ‘get_modem_info’:
drivers/staging/dgrp/dgrp_tty.c:2267: error: implicit declaration of function ‘put_user’
drivers/staging/dgrp/dgrp_tty.c: In function ‘set_modem_info’:
drivers/staging/dgrp/dgrp_tty.c:2283: error: implicit declaration of function ‘access_ok’
drivers/staging/dgrp/dgrp_tty.c:2283: error: ‘VERIFY_READ’ undeclared (first use in this function)
drivers/staging/dgrp/dgrp_tty.c:2283: error: (Each undeclared identifier is reported only once
drivers/staging/dgrp/dgrp_tty.c:2283: error: for each function it appears in.)
drivers/staging/dgrp/dgrp_tty.c:2287: error: implicit declaration of function ‘get_user’
drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_digigetedelay’:
drivers/staging/dgrp/dgrp_tty.c:2474: error: implicit declaration of function ‘copy_to_user’
drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_ioctl’:
drivers/staging/dgrp/dgrp_tty.c:2618: error: ‘VERIFY_WRITE’ undeclared (first use in this function)
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
See also http://kisskb.ellerman.id.au/kisskb/buildresult/7277002/
drivers/staging/dgrp/dgrp_mon_ops.c | 1 +
drivers/staging/dgrp/dgrp_specproc.c | 1 +
drivers/staging/dgrp/dgrp_tty.c | 1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgrp/dgrp_mon_ops.c b/drivers/staging/dgrp/dgrp_mon_ops.c
index 268dcb9..4792d05 100644
--- a/drivers/staging/dgrp/dgrp_mon_ops.c
+++ b/drivers/staging/dgrp/dgrp_mon_ops.c
@@ -38,6 +38,7 @@
#include <linux/sched.h>
#include <asm/unaligned.h>
#include <linux/proc_fs.h>
+#include <linux/uaccess.h>
#include "dgrp_common.h"
diff --git a/drivers/staging/dgrp/dgrp_specproc.c b/drivers/staging/dgrp/dgrp_specproc.c
index 28f5c9a..a5840e7 100644
--- a/drivers/staging/dgrp/dgrp_specproc.c
+++ b/drivers/staging/dgrp/dgrp_specproc.c
@@ -39,6 +39,7 @@
#include <linux/proc_fs.h>
#include <linux/ctype.h>
#include <linux/seq_file.h>
+#include <linux/uaccess.h>
#include <linux/vmalloc.h>
#include "dgrp_common.h"
diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
index 7d7de87..72f6fcf 100644
--- a/drivers/staging/dgrp/dgrp_tty.c
+++ b/drivers/staging/dgrp/dgrp_tty.c
@@ -40,6 +40,7 @@
#include <linux/tty.h>
#include <linux/tty_flip.h>
#include <linux/sched.h>
+#include <linux/uaccess.h>
#include "dgrp_common.h"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] staging: dgrp: Add missing #include <linux/uaccess.h>
2012-09-27 18:38 [PATCH -next] staging: dgrp: Add missing #include <linux/uaccess.h> Geert Uytterhoeven
@ 2012-10-11 12:40 ` Geert Uytterhoeven
2012-10-17 20:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-10-11 12:40 UTC (permalink / raw)
To: Bill Pemberton, Greg Kroah-Hartman
Cc: devel, linux-kernel, linux-next, Geert Uytterhoeven
On Thu, Sep 27, 2012 at 8:38 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On m68k:
Now also in mainline, cfr.
http://kisskb.ellerman.id.au/kisskb/buildresult/7344531/
> drivers/staging/dgrp/dgrp_mon_ops.c: In function ‘dgrp_mon_read’:
> drivers/staging/dgrp/dgrp_mon_ops.c:304: error: implicit declaration of function ‘copy_to_user’
> drivers/staging/dgrp/dgrp_specproc.c: In function ‘config_proc_write’:
> drivers/staging/dgrp/dgrp_specproc.c:470: error: implicit declaration of function ‘copy_from_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘drp_wmove’:
> drivers/staging/dgrp/dgrp_tty.c:1284: error: implicit declaration of function ‘copy_from_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘get_modem_info’:
> drivers/staging/dgrp/dgrp_tty.c:2267: error: implicit declaration of function ‘put_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘set_modem_info’:
> drivers/staging/dgrp/dgrp_tty.c:2283: error: implicit declaration of function ‘access_ok’
> drivers/staging/dgrp/dgrp_tty.c:2283: error: ‘VERIFY_READ’ undeclared (first use in this function)
> drivers/staging/dgrp/dgrp_tty.c:2283: error: (Each undeclared identifier is reported only once
> drivers/staging/dgrp/dgrp_tty.c:2283: error: for each function it appears in.)
> drivers/staging/dgrp/dgrp_tty.c:2287: error: implicit declaration of function ‘get_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_digigetedelay’:
> drivers/staging/dgrp/dgrp_tty.c:2474: error: implicit declaration of function ‘copy_to_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_ioctl’:
> drivers/staging/dgrp/dgrp_tty.c:2618: error: ‘VERIFY_WRITE’ undeclared (first use in this function)
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> See also http://kisskb.ellerman.id.au/kisskb/buildresult/7277002/
>
> drivers/staging/dgrp/dgrp_mon_ops.c | 1 +
> drivers/staging/dgrp/dgrp_specproc.c | 1 +
> drivers/staging/dgrp/dgrp_tty.c | 1 +
> 3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/dgrp/dgrp_mon_ops.c b/drivers/staging/dgrp/dgrp_mon_ops.c
> index 268dcb9..4792d05 100644
> --- a/drivers/staging/dgrp/dgrp_mon_ops.c
> +++ b/drivers/staging/dgrp/dgrp_mon_ops.c
> @@ -38,6 +38,7 @@
> #include <linux/sched.h>
> #include <asm/unaligned.h>
> #include <linux/proc_fs.h>
> +#include <linux/uaccess.h>
>
> #include "dgrp_common.h"
>
> diff --git a/drivers/staging/dgrp/dgrp_specproc.c b/drivers/staging/dgrp/dgrp_specproc.c
> index 28f5c9a..a5840e7 100644
> --- a/drivers/staging/dgrp/dgrp_specproc.c
> +++ b/drivers/staging/dgrp/dgrp_specproc.c
> @@ -39,6 +39,7 @@
> #include <linux/proc_fs.h>
> #include <linux/ctype.h>
> #include <linux/seq_file.h>
> +#include <linux/uaccess.h>
> #include <linux/vmalloc.h>
>
> #include "dgrp_common.h"
> diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
> index 7d7de87..72f6fcf 100644
> --- a/drivers/staging/dgrp/dgrp_tty.c
> +++ b/drivers/staging/dgrp/dgrp_tty.c
> @@ -40,6 +40,7 @@
> #include <linux/tty.h>
> #include <linux/tty_flip.h>
> #include <linux/sched.h>
> +#include <linux/uaccess.h>
>
> #include "dgrp_common.h"
>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] staging: dgrp: Add missing #include <linux/uaccess.h>
2012-10-11 12:40 ` Geert Uytterhoeven
@ 2012-10-17 20:56 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2012-10-17 20:56 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Bill Pemberton, devel, linux-next, linux-kernel
On Thu, Oct 11, 2012 at 02:40:30PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 27, 2012 at 8:38 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On m68k:
>
> Now also in mainline, cfr.
> http://kisskb.ellerman.id.au/kisskb/buildresult/7344531/
>
> > drivers/staging/dgrp/dgrp_mon_ops.c: In function ‘dgrp_mon_read’:
> > drivers/staging/dgrp/dgrp_mon_ops.c:304: error: implicit declaration of function ‘copy_to_user’
> > drivers/staging/dgrp/dgrp_specproc.c: In function ‘config_proc_write’:
> > drivers/staging/dgrp/dgrp_specproc.c:470: error: implicit declaration of function ‘copy_from_user’
> > drivers/staging/dgrp/dgrp_tty.c: In function ‘drp_wmove’:
> > drivers/staging/dgrp/dgrp_tty.c:1284: error: implicit declaration of function ‘copy_from_user’
> > drivers/staging/dgrp/dgrp_tty.c: In function ‘get_modem_info’:
> > drivers/staging/dgrp/dgrp_tty.c:2267: error: implicit declaration of function ‘put_user’
> > drivers/staging/dgrp/dgrp_tty.c: In function ‘set_modem_info’:
> > drivers/staging/dgrp/dgrp_tty.c:2283: error: implicit declaration of function ‘access_ok’
> > drivers/staging/dgrp/dgrp_tty.c:2283: error: ‘VERIFY_READ’ undeclared (first use in this function)
> > drivers/staging/dgrp/dgrp_tty.c:2283: error: (Each undeclared identifier is reported only once
> > drivers/staging/dgrp/dgrp_tty.c:2283: error: for each function it appears in.)
> > drivers/staging/dgrp/dgrp_tty.c:2287: error: implicit declaration of function ‘get_user’
> > drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_digigetedelay’:
> > drivers/staging/dgrp/dgrp_tty.c:2474: error: implicit declaration of function ‘copy_to_user’
> > drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_ioctl’:
> > drivers/staging/dgrp/dgrp_tty.c:2618: error: ‘VERIFY_WRITE’ undeclared (first use in this function)
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Yes, now in my tree, will go to Linus this week.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-17 20:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 18:38 [PATCH -next] staging: dgrp: Add missing #include <linux/uaccess.h> Geert Uytterhoeven
2012-10-11 12:40 ` Geert Uytterhoeven
2012-10-17 20:56 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).