From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: David Rientjes <rientjes@google.com>,
James Morris <jmorris@namei.org>,
linux-security-module <linux-security-module@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
Dmitry Kasatkin <dmitry.kasatkin@intel.com>,
axboe <axboe@kernel.dk>
Subject: Re: [PATCH] ima: fix part_pack_uuid() build error
Date: Sun, 24 Feb 2013 10:15:06 -0500 [thread overview]
Message-ID: <1361718906.2908.48.camel@falcor1.watson.ibm.com> (raw)
In-Reply-To: <5127E111.6030605@infradead.org>
On Fri, 2013-02-22 at 13:20 -0800, Randy Dunlap wrote:
> On 02/22/13 11:46, Mimi Zohar wrote:
> > Fix a build error when CONFIG_BLOCK is not enabled by defining
> > a wrapper called ima_part_pack_uuid(). The wrapper returns
> > -EINVAL, when CONFIG_BLOCK is not defined.
>
> Some function wrapper for the case of BLOCK not enabled should be handled
> where the function is defined, not where it is called.
> That's how it is usually done in Linux.
Ok, I've renamed the wrapper from ima_part_pack_uuid() to
blk_part_pack_uuid() and moved it to linux/genhd.h
thanks,
Mimi
prev parent reply other threads:[~2013-02-24 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 19:46 [PATCH] ima: fix part_pack_uuid() build error Mimi Zohar
2013-02-22 20:35 ` David Rientjes
2013-02-22 21:20 ` Randy Dunlap
2013-02-24 15:15 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361718906.2908.48.camel@falcor1.watson.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=axboe@kernel.dk \
--cc=dmitry.kasatkin@intel.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).