From: Johannes Berg <johannes@sipsolutions.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: James Hogan <james.hogan@imgtec.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Daniel Santos <daniel.santos@pobox.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-next <linux-next@vger.kernel.org>,
linux-metag <linux-metag@vger.kernel.org>
Subject: Re: [PATCH] compiler.h: don't use temporary variable in __compiletime_assert()
Date: Tue, 13 May 2014 09:31:33 +0200 [thread overview]
Message-ID: <1399966293.4137.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20140512141642.5eb526deed5ea32ad5bced72@linux-foundation.org>
On Mon, 2014-05-12 at 14:16 -0700, Andrew Morton wrote:
> > I don't understand why your patch should break things, I suspect it's
> > related to the sparse behaviour you're trying to work around, but can we
> > please drop this patch until a more portable workaround can be found?
>
> Older gcc's often have this problem.
>
> I suppose that build bustage is more serious than sparse false
> positives so yes, let's please try to find an alternative.
Since most people probably don't use sparse without compiling (in fact
it's pretty difficult to do so) I'll just send a patch to disable
__compiletime_assert for sparse - any objections?
johannes
next prev parent reply other threads:[~2014-05-13 7:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1399530685-7749-1-git-send-email-johannes@sipsolutions.net>
2014-05-12 13:42 ` [PATCH] compiler.h: don't use temporary variable in __compiletime_assert() James Hogan
2014-05-12 14:38 ` Johannes Berg
2014-05-12 14:56 ` James Hogan
2014-05-12 21:16 ` Andrew Morton
2014-05-13 7:31 ` Johannes Berg [this message]
2014-05-13 8:53 ` James Hogan
2014-05-13 9:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399966293.4137.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox