From: Joe Perches <joe@perches.com>
To: Bilel DRIRA <bilel.dr@gmail.com>
Cc: marek.belisko@gmail.com, gregkh@linuxfoundation.org,
tapaswenipathak@gmail.com, gdonald@gmail.com,
aybuke.147@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix braces warning
Date: Tue, 03 Feb 2015 11:05:08 -0800 [thread overview]
Message-ID: <1422990308.30476.37.camel@perches.com> (raw)
In-Reply-To: <1422989883-16937-1-git-send-email-bilel.dr@gmail.com>
On Tue, 2015-02-03 at 19:58 +0100, Bilel DRIRA wrote:
> This patch fix the checkpatch.pl WARNING:
[]
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
[]
> @@ -1963,11 +1948,10 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
> ft1000_read_reg(dev,
> FT1000_REG_MAG_DFSR);
> }
> - if (tempword & 0x1f) {
> + if (tempword & 0x1f)
> ft1000_copy_up_pkt(dev);
> - } else {
> + else
> break;
> - }
> cnt++;
> } while (cnt < MAX_RCV_LOOP);
>
trivia: the logic here is generally better inverted:
if (!(tempword & 0x1f))
break;
ft1000_copy_up_pkt(dev);
cnt++;
} while (cnt < etc...)
next prev parent reply other threads:[~2015-02-03 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 18:58 [PATCH] staging: ft1000: fix braces warning Bilel DRIRA
2015-02-03 19:05 ` Joe Perches [this message]
2015-02-03 20:05 ` bill
2015-02-03 20:14 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2015-02-03 20:26 Bilel DRIRA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422990308.30476.37.camel@perches.com \
--to=joe@perches.com \
--cc=aybuke.147@gmail.com \
--cc=bilel.dr@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).