Re: linux-next: build failure after merge of the arm-soc tree

Nicolas Ferre
2011-10-04T10:17:09Z

On 10/04/2011 09:40 AM, Arnd Bergmann :
> On Tuesday 04 October 2011, Stephen Rothwell wrote:
>> After merging the arm-soc tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> ERROR: "clk_enable" [drivers/misc/atmel_pwm.ko] undefined!
>> ERROR: "clk_disable" [drivers/misc/atmel_pwm.ko] undefined!
>> ERROR: "clk_put" [drivers/misc/atmel_pwm.ko] undefined!
>> ERROR: "clk_get_rate" [drivers/misc/atmel_pwm.ko] undefined!
>> ERROR: "clk_get" [drivers/misc/atmel_pwm.ko] undefined!
>>
>> Caused by commit 9dccc010c816 ("ARM: at91: remove dependency for Atmel
>> PWM driver selector in Kconfig").
>>
>> I have used the arm-soc tree from next-20110930 for today.
>
> Ah, thanks for tracking this down. I actually noticed the same
> problem on an ARM build but did not realize it was from one of
> the patches I had jut put in there myself.
>
> I'm really glad I didn't send this to Linus cc:stable yet then.
> Nicolas, in my randconfig branch, I've fixed this by adding
>
> depends on HAVE_CLK
>
> which I think is the right solution. I'll replace your patch
> with one that does this if you don't mind.

Sure, thanks a lot for fixing this!

> I'd also remove the stable tag for this patch, because it can
> have unintended side-effects on other architectures.

Yes, I have not figured out it can have such an impact.

Thanks for your help, best regards,
--
Nicolas Ferre