From: Roger Willcocks <roger@filmlight.ltd.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jens Axboe <axboe@kernel.dk>, David Jeffery <djeffery@redhat.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
Ben Myers <bpm@sgi.com>,
linux-next@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: linux-next: manual merge of the block tree with the xfs tree
Date: Wed, 02 Sep 2015 14:34:51 +0100 [thread overview]
Message-ID: <1441200891.17400.1277.camel@localhost.localdomain> (raw)
In-Reply-To: <20150902230342.125e23ce@canb.auug.org.au>
On Wed, 2015-09-02 at 23:03 +1000, Stephen Rothwell wrote:
> Hi Roger,
>
> On Wed, 2 Sep 2015 10:45:29 +0100 Roger Willcocks <roger@filmlight.ltd.uk> wrote:
> >
> > On 2 Sep 2015, at 03:16, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > > ++ if (!ioend->io_error)
> > > ++ ioend->io_error = bio->bi_error;
> >
> > This is incorrect; it can clear an earlier error status. It should probably read:
> >
> > if (!ioend->io_error && bio->bi_error)
> > ioend->io_error = bio->bi_error;
>
> Thanks, I will use that from tomorrow.
>
Huh, now I've had my coffee, that extra check doesn't add anything.
(There's no harm done in assigning zero to io_error if it's already
zero.) Apologies for the noise.
--
Roger Willcocks <roger@filmlight.ltd.uk>
next prev parent reply other threads:[~2015-09-02 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 2:16 linux-next: manual merge of the block tree with the xfs tree Stephen Rothwell
2015-09-02 9:45 ` Roger Willcocks
2015-09-02 13:03 ` Stephen Rothwell
2015-09-02 13:34 ` Roger Willcocks [this message]
2015-09-02 13:37 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2019-07-03 3:19 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441200891.17400.1277.camel@localhost.localdomain \
--to=roger@filmlight.ltd.uk \
--cc=axboe@kernel.dk \
--cc=bpm@sgi.com \
--cc=djeffery@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).