From: Michael Zoran <mzoran@crowfest.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>
Cc: kernel-build-reports@lists.linaro.org,
linaro-kernel@lists.linaro.org, linux-next@vger.kernel.org
Subject: Re: next-20170201 build: 3 failures 3 warnings (next-20170201)
Date: Wed, 01 Feb 2017 05:45:31 -0800 [thread overview]
Message-ID: <1485956731.16868.1.camel@crowfest.net> (raw)
In-Reply-To: <20170201111752.GI13721@kroah.com>
On Wed, 2017-02-01 at 12:17 +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 01, 2017 at 10:56:27AM +0000, Mark Brown wrote:
> > On Wed, Feb 01, 2017 at 10:38:07AM +0000, Build bot for Mark Brown
> > wrote:
> >
> > Today's -next fails to build both arm and arm64 allmodconfigs due
> > to:
> >
> > > arm64-allmodconfig
> > > ../drivers/staging/bcm2835-audio/bcm2835-vchiq.c:97:9: error:
> > > implicit declaration of function 'vchi_msg_queue' [-
> > > Werror=implicit-function-declaration]
> > > arm-allmodconfig
> > > ../drivers/staging/bcm2835-audio/bcm2835-vchiq.c:97:9: error:
> > > implicit declaration of function 'vchi_msg_queue' [-
> > > Werror=implicit-function-declaration]
> > > ../drivers/staging/media/platform/bcm2835/mmal-vchiq.c:453:8:
> > > error: implicit declaration of function 'vchi_msg_queue' [-
> > > Werror=implicit-function-declaration]
> >
> > caused by that driver being added.
>
> Doesn't look like vchi_msg_queue is ever exported for modules to use.
> Michael, care to make up a patch for that?
>
> Also, the build warning is odd, shouldn't the include files point to
> the
> correct .h file for this?
>
This is because vchi_msg_queue was replaced with
vchi_queue_kernel_message and vchi_queue_user_message.
vchi_msg_queue was removed from the header and made static since it's
no longer needed by other modules.
The correct fix is to replace vchi_msg_queue with
vchi_queue_kernel_message in the two dependent drivers.
I should have a patch shortly, but I'm currently having some very slow
network issues.
prev parent reply other threads:[~2017-02-01 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 10:38 next-20170201 build: 3 failures 3 warnings (next-20170201) Build bot for Mark Brown
2017-02-01 10:56 ` Mark Brown
2017-02-01 11:17 ` Greg Kroah-Hartman
2017-02-01 13:45 ` Michael Zoran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485956731.16868.1.camel@crowfest.net \
--to=mzoran@crowfest.net \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox