From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FB4BC433EA for ; Tue, 21 Jul 2020 12:34:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A9122073A for ; Tue, 21 Jul 2020 12:34:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725984AbgGUMee (ORCPT ); Tue, 21 Jul 2020 08:34:34 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:49670 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728557AbgGUMee (ORCPT ); Tue, 21 Jul 2020 08:34:34 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E8E19B16BE2F347E0C0B; Tue, 21 Jul 2020 20:34:30 +0800 (CST) Received: from [127.0.0.1] (10.174.179.238) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Tue, 21 Jul 2020 20:34:22 +0800 Subject: Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX To: David Miller CC: , , , , , , , References: <20200716173247.78912-1-cuibixuan@huawei.com> <20200719100522.220a6f5a@hermes.lan> <866b4a34-cd4e-0120-904f-13669257a765@huawei.com> <20200720.183849.626605331445628040.davem@davemloft.net> From: Bixuan Cui Message-ID: <16aa9f4a-583e-2fd1-c14f-a3b2a6228436@huawei.com> Date: Tue, 21 Jul 2020 20:34:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200720.183849.626605331445628040.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.238] X-CFilter-Loop: Reflected Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 2020/7/21 9:38, David Miller wrote: > From: Bixuan Cui > Date: Mon, 20 Jul 2020 09:58:39 +0800 > >> Fix the warning: [-Werror=-Wframe-larger-than=] >> >> drivers/net/ethernet/neterion/vxge/vxge-main.c: >> In function'VXGE_COMPLETE_VPATH_TX.isra.37': >> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: >> warning: the frame size of 1056 bytes is larger than 1024 bytes >> >> Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't >> have much impact on performance and functionality. >> >> Signed-off-by: Bixuan Cui >> Signed-off-by: Stephen Hemminger >> --- >> v2: Dropping the NR_SKB_COMPLETED to 16. > Applied. thanks.