From: Pankaj Gupta <pagupta@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Dan Williams <dan.j.williams@intel.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: linux-next: build failure after merge of the nvdimm tree
Date: Thu, 20 Jun 2019 06:30:19 -0400 (EDT) [thread overview]
Message-ID: <1700587723.36256070.1561026619938.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190620192939.139bf5c0@canb.auug.org.au>
> Hi Dan,
>
> After merging the nvdimm tree, today's linux-next build (i386 defconfig)
> failed like this:
>
> drivers/md/dm-table.c: In function 'device_synchronous':
> drivers/md/dm-table.c:897:9: error: implicit declaration of function
> 'dax_synchronous'; did you mean 'device_synchronous'?
> [-Werror=implicit-function-declaration]
> return dax_synchronous(dev->dax_dev);
> ^~~~~~~~~~~~~~~
> device_synchronous
> drivers/md/dm-table.c: In function 'dm_table_set_restrictions':
> drivers/md/dm-table.c:1925:4: error: implicit declaration of function
> 'set_dax_synchronous'; did you mean 'device_synchronous'?
> [-Werror=implicit-function-declaration]
> set_dax_synchronous(t->md->dax_dev);
> ^~~~~~~~~~~~~~~~~~~
> device_synchronous
> cc1: some warnings being treated as errors
>
> Caused by commit
>
> 38887edec247 ("dm: enable synchronous dax")
>
> CONFIG_DAX is not set for this build.
Moving 'dax_synchronous' & 'set_dax_synchronous' function declaration
out of CONFIG_DAX should fix this. This will make compiler aware about
'device_synchronous' function for non DAX archs as well.
Thanks,
Pankaj
>
> I have reverted that commit for today.
> --
> Cheers,
> Stephen Rothwell
>
next prev parent reply other threads:[~2019-06-20 10:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 9:29 linux-next: build failure after merge of the nvdimm tree Stephen Rothwell
2019-06-20 10:30 ` Pankaj Gupta [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-16 9:10 Stephen Rothwell
2022-05-16 18:05 ` Dan Williams
2021-08-30 7:09 Stephen Rothwell
2021-08-30 7:10 ` Christoph Hellwig
2021-08-30 7:15 ` Gao Xiang
2019-07-05 7:20 Stephen Rothwell
2019-07-05 8:45 ` Pankaj Gupta
2019-07-05 11:09 ` Stephen Rothwell
2019-07-05 11:14 ` Pankaj Gupta
2019-07-05 22:32 ` Dan Williams
2019-07-05 23:48 ` Stephen Rothwell
2018-04-09 3:16 Stephen Rothwell
2018-04-09 3:38 ` Oliver
2018-04-09 7:34 ` Oliver
2018-04-09 17:11 ` Dan Williams
2018-04-09 18:14 ` Dan Williams
2017-11-03 7:19 Stephen Rothwell
2017-11-03 16:04 ` Dan Williams
2017-09-04 7:34 Stephen Rothwell
2017-09-04 18:34 ` Dan Williams
2017-04-24 6:11 Stephen Rothwell
2017-04-24 8:39 ` Al Viro
2017-04-24 23:29 ` Dan Williams
2017-04-25 22:22 ` Dan Williams
2016-07-22 6:13 Stephen Rothwell
2016-07-23 1:04 ` Dan Williams
2016-07-23 3:54 ` Dan Williams
2016-07-21 6:13 Stephen Rothwell
2016-07-21 21:33 ` Dan Williams
2016-03-27 9:50 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1700587723.36256070.1561026619938.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox