From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C300EC433EF for ; Fri, 22 Oct 2021 09:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5B9261163 for ; Fri, 22 Oct 2021 09:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232412AbhJVJFM (ORCPT ); Fri, 22 Oct 2021 05:05:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44475 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232404AbhJVJFM (ORCPT ); Fri, 22 Oct 2021 05:05:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634893374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OYnkK/ugidI49BFFj5mxnrcEA6t1Rlovv9DXEeR+Ht4=; b=SAMjUAGg+uY5yIUNgpp3wd9NvPXi24GriLyiYuZzvGXiAMSCLk9xXFCgyRUOquGaE0f0uu 3y+V4YNRLJEeTtXZFEWKl/Ul0zNx3zIO89sQsJT/aliVt7K3L25AaiIc2nA5ppt5b59lZf ox3ZfKl9HH9v+8+lMDlrodxVCLdbsa0= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-464-cx2mvM1UO1W92R6qyjl-Uw-1; Fri, 22 Oct 2021 05:02:53 -0400 X-MC-Unique: cx2mvM1UO1W92R6qyjl-Uw-1 Received: by mail-ed1-f71.google.com with SMTP id h19-20020aa7de13000000b003db6ad5245bso3073222edv.9 for ; Fri, 22 Oct 2021 02:02:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OYnkK/ugidI49BFFj5mxnrcEA6t1Rlovv9DXEeR+Ht4=; b=6ktbci9u5S7aCPlHy9IieHCU7qJntw8R19aT2She+TisT0aGVGaadNQfqbrSWgZehp XHVdUskou02Eclsuyh4JafymX7idneoGvS3TGbWBq7neBBdvvDR0WehKavQUcHmtkocD sa1B4tqKISoLlYEML/vt0cch3Fz2usI4zSB2xqAwElHpdXDDCHX+sgwIwJbhhU/HsQ+G ftrFd8Mu+Ua5BZ6KKfvMPojRmHvUz8W8RNI9mFnY7gV8W4PHFJ7VOTcRc5/lxQMISBcW 9l7rXmx5RDO/UsmQYRouiXZDeb/uwo/kP6kszxNyxBSdnwZlvwV9okUkZqI+H7TMlb9/ NXUw== X-Gm-Message-State: AOAM530S4d7IAu0yGZc8D3OsnW6iDB6r4Q4y0JImPUTUASchSyFrK6sp J0uxpiS6F6KxmlSeXPdgMOKXqGjhXga0amtok4YEIuCnrK3ZddJSrsXvvYrcdNZFr7pIYUmSStW RAoiijoO9L5QscbGMVKZ5zA== X-Received: by 2002:a50:d558:: with SMTP id f24mr15678515edj.305.1634893371919; Fri, 22 Oct 2021 02:02:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJye92nZmEiPCT90la+U7ulelNZVortvgf1oMgs7297MBuXsB9bBlaq0BeoT6/NG9jphWx2M4g== X-Received: by 2002:a50:d558:: with SMTP id f24mr15678480edj.305.1634893371628; Fri, 22 Oct 2021 02:02:51 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id j11sm3485626ejt.114.2021.10.22.02.02.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Oct 2021 02:02:51 -0700 (PDT) Message-ID: <17e828ee-7338-e34e-db10-8af10d705a88@redhat.com> Date: Fri, 22 Oct 2021 11:02:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: linux-next: build warnings after merge of the drivers-x86 tree Content-Language: en-US To: Jonathan Corbet , Stephen Rothwell , Vadim Pasternak Cc: Mark Gross , Linux Kernel Mailing List , Linux Next Mailing List , Mauro Carvalho Chehab References: <20211021184735.794b22a7@canb.auug.org.au> <20211022070452.28924855@canb.auug.org.au> <87lf2mjd8b.fsf@meer.lwn.net> From: Hans de Goede In-Reply-To: <87lf2mjd8b.fsf@meer.lwn.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hi, On 10/21/21 23:10, Jonathan Corbet wrote: > [CC += Mauro] > > Stephen Rothwell writes: > >> On Thu, 21 Oct 2021 09:07:03 +0000 Vadim Pasternak wrote: >>> >>> What is wrong with the syntax at line 230 and where blank line is expected? >>> >>> What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/bios_active_image >>> What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/bios_auth_fail >>> What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/bios_upgrade_fail >>> Date: October 2021 <--- this is line 230 >>> KernelVersion: 5.16 >> >> I am sorry, I don't know. Added Jon to cc for advice. > > The problem isn't that line at all, it's the use of a bulleted list a > few lines further down; that doesn't work in ABI files. > > Mauro, this ABI stuff is fragile, and this kind of problem occurs fairly > often. How hard would it be to (1) make it a bit more robust, (2) make > it issue useful warnings where it can't be robust, and (3) properly > document the restrictions for ABI files? > > Meanwhile, the attached patch fixes it; feel free to use it or to just > fold the change into your work. Thank you. I've added the fix (as is) to my platform-drivers-x86/review-hans branch. Once the lkp kernel test robot has done a successful build of that branch (it also contains some other new patches) I'll push this to for-next resolving these warnings. Regards, Hans > ----------------------------- > From 97371e6afda75eef71b7d5d1794645e5cfaf1811 Mon Sep 17 00:00:00 2001 > From: Jonathan Corbet > Date: Thu, 21 Oct 2021 15:02:43 -0600 > Subject: [PATCH] docs: ABI: fix documentation warning in sysfs-driver-mlxreg-io > > The use of a Sphinx list within this ABI file caused the following warning: > > Documentation/ABI/stable/sysfs-driver-mlxreg-io:230: WARNING: Unexpected indentation. > Documentation/ABI/stable/sysfs-driver-mlxreg-io:230: WARNING: Block quote ends without a blank line; unexpected unindent. > > Remove the bullets to make the warning go away and get proper formatting. > > Reported-by: Stephen Rothwell > Signed-off-by: Jonathan Corbet > --- > .../ABI/stable/sysfs-driver-mlxreg-io | 23 +++++++++++-------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io b/Documentation/ABI/stable/sysfs-driver-mlxreg-io > index c84795ccecad..12c3f895cd2f 100644 > --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io > +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io > @@ -231,16 +231,19 @@ Date: October 2021 > KernelVersion: 5.16 > Contact: Vadim Pasternak > Description: The files represent BIOS statuses: > - - bios_active_image: location of current active BIOS image: > - 0: Top, 1: Bottom. > - The reported value should correspond to value expected by OS > - in case of BIOS safe mode is 0. This bit is related to Intel > - top-swap feature of DualBios on the same flash. > - - bios_auth_fail: BIOS upgrade is failed because provided BIOS > - image is not signed correctly. > - - bios_upgrade_fail: BIOS upgrade is failed by some other > - reason not because authentication. For example due to > - physical SPI flash problem. > + > + bios_active_image: location of current active BIOS image: > + 0: Top, 1: Bottom. > + The reported value should correspond to value expected by OS > + in case of BIOS safe mode is 0. This bit is related to Intel > + top-swap feature of DualBios on the same flash. > + > + bios_auth_fail: BIOS upgrade is failed because provided BIOS > + image is not signed correctly. > + > + bios_upgrade_fail: BIOS upgrade is failed by some other > + reason not because authentication. For example due to > + physical SPI flash problem. > > The files are read only. > >