linux-next: next-20081114 build failure

linux-next: next-20081114 build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Hi James, David,

Today's linux-next build (mips defconfig) failed like this:

fs/nfsctl.c:45: error: implicit declaration of function 'current_cred'

This is why you need explicit includes ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: next-20081114 build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi Dave,

Today's linux-next build (mips allmodconfig) failed like this:

drivers/net/dm9000.c:1450: error: expected ')' before ';' token
drivers/net/dm9000.c:1455: error: expected ';' before '}' token

Caused by commit 4cf1653aa90c6320dc8032443b5e322820aa28b1 ("netdevice:
safe convert to netdev_priv() #part-2") which left a closing ')' off one
of the conversions.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: next-20081114 build failure

[David Howells]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Today's linux-next build (mips defconfig) failed like this:
> 
> fs/nfsctl.c:45: error: implicit declaration of function 'current_cred'
> 
> This is why you need explicit includes ...

Oops.  I really need to cull the number of creds trees I've got.  I didn't
apply your patches to all of them.

David

Re: linux-next: next-20081114 build failure

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sun, 16 Nov 2008 22:36:12 +1100

> Today's linux-next build (mips allmodconfig) failed like this:
> 
> drivers/net/dm9000.c:1450: error: expected ')' before ';' token
> drivers/net/dm9000.c:1455: error: expected ';' before '}' token

I just checked the following fix into net-next-2.6

Let me know if it doesn't work

dm9000: Fix build error.

Reported by Stephen Rothwell:

drivers/net/dm9000.c:1450: error: expected ')' before ';' token
drivers/net/dm9000.c:1455: error: expected ';' before '}' token

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/dm9000.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index 0d9a217..bcf9291 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -1447,7 +1447,7 @@ dm9000_drv_remove(struct platform_device *pdev)
 	platform_set_drvdata(pdev, NULL);
 
 	unregister_netdev(ndev);
-	dm9000_release_board(pdev, (board_info_t *) netdev_priv(ndev);
+	dm9000_release_board(pdev, (board_info_t *) netdev_priv(ndev));
 	free_netdev(ndev);		/* free device structure */
 
 	dev_dbg(&pdev->dev, "released and freed device\n");
-- 
1.5.6.5