From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Vegard Nossum" Subject: Re: linux-next: Tree for July 18: warning at kernel/lockdep.c:2068 trace_hardirqs_on_caller Date: Sat, 19 Jul 2008 14:59:12 +0200 Message-ID: <19f34abd0807190559y2fe5ebf9h7095793e82de3122@mail.gmail.com> References: <20080718195352.e562a00f.sfr@canb.auug.org.au> <200807190928.33978.m.kozlowski@tuxland.pl> <19f34abd0807190255x304173d4wf2bfabb2d5bce511@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from rv-out-0506.google.com ([209.85.198.233]:6026 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599AbYGSM7N (ORCPT ); Sat, 19 Jul 2008 08:59:13 -0400 Received: by rv-out-0506.google.com with SMTP id k40so682365rvb.1 for ; Sat, 19 Jul 2008 05:59:13 -0700 (PDT) In-Reply-To: <19f34abd0807190255x304173d4wf2bfabb2d5bce511@mail.gmail.com> Content-Disposition: inline Sender: linux-next-owner@vger.kernel.org List-ID: To: Mariusz Kozlowski , Dave Hansen , Greg Kroah-Hartman Cc: Stephen Rothwell , kernel-testers@vger.kernel.org, linux-next@vger.kernel.org, LKML , Pekka Enberg On Sat, Jul 19, 2008 at 11:55 AM, Vegard Nossum wrote: > What I don't get here is how SLUB can be used this early in the boot > process. Notice that this is still miles away from the > > SLUB: Genslabs=12, HWalign=128, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 > > line, which comes much later. And that kobject_init() _is_ calling > kzalloc() via verify_dynamic_kobject_allocation(). Isn't this an > error? > > (Unfortunately, my "git log" doesn't turn up any recent changes for > any of the affected code paths here.) Ehe... and this is the reason why: The code was added by this patch: commit 0e3638d1e04040121af00195f7e4628078246489 Author: Dave Hansen Date: Thu Mar 16 17:30:16 2006 -0800 warn when statically-allocated kobjects are used ..which only exists in -next. Is that just a truly ancient patch, or did somebody forget to adjust their clock? (Stephen: Maybe this has been answered before, but what's the best way to figure out where it came from?) Vegard -- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036