public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Konrad Wilk <konrad.wilk@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org
Subject: RE: [PATCH -next] staging: ramster: depends on NET
Date: Thu, 11 Oct 2012 13:10:02 -0700 (PDT)	[thread overview]
Message-ID: <1a20296e-60c2-4b03-b322-5ac060b38b52@default> (raw)
In-Reply-To: <5076F503.3070808@xenotime.net>

> From: Randy Dunlap [mailto:rdunlap@xenotime.net]
> Sent: Thursday, October 11, 2012 10:34 AM
> To: Stephen Rothwell
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Dan Magenheimer; Konrad Wilk; Greg
> Kroah-Hartman; devel@driverdev.osuosl.org
> Subject: [PATCH -next] staging: ramster: depends on NET
> 
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> ramster uses network interfaces that are only present when
> CONFIG_NET is enabled, so it should depend on NET.

Yep, thanks for catching!

Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
 
> Fixes these build errors:
> 
> drivers/built-in.o: In function `sc_kref_release':
> tcp.c:(.text+0x24b9af): undefined reference to `sock_release'
> drivers/built-in.o: In function `r2net_open_listening_sock':
> tcp.c:(.text+0x24ca2b): undefined reference to `sock_create'
> tcp.c:(.text+0x24cb91): undefined reference to `sock_release'
> drivers/built-in.o: In function `r2net_recv_tcp_msg':
> tcp.c:(.text+0x24cdbd): undefined reference to `sock_recvmsg'
> drivers/built-in.o: In function `r2net_send_tcp_msg':
> tcp.c:(.text+0x24d341): undefined reference to `sock_sendmsg'
> drivers/built-in.o: In function `r2net_start_connect':
> tcp.c:(.text+0x24d8fa): undefined reference to `sock_create'
> drivers/built-in.o: In function `r2net_shutdown_sc':
> tcp.c:(.text+0x24e30c): undefined reference to `kernel_sock_shutdown'
> drivers/built-in.o: In function `r2net_accept_one':
> tcp.c:(.text+0x24f392): undefined reference to `sock_create_lite'
> tcp.c:(.text+0x24f3c3): undefined reference to `sock_release'
> drivers/built-in.o: In function `r2net_stop_listening':
> (.text+0x250f63): undefined reference to `sock_release'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: dan.magenheimer@oracle.com
> Cc: konrad.wilk@oracle.com
> ---
>  drivers/staging/ramster/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20121011.orig/drivers/staging/ramster/Kconfig
> +++ linux-next-20121011/drivers/staging/ramster/Kconfig
> @@ -18,6 +18,7 @@ config ZCACHE2
>  config RAMSTER
>  	bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
>  	depends on CONFIGFS_FS=y && SYSFS=y && !HIGHMEM && ZCACHE2=y
> +	depends on NET
>  	# must ensure struct page is 8-byte aligned
>  	select HAVE_ALIGNED_STRUCT_PAGE if !64_BIT
>  	default n

      reply	other threads:[~2012-10-11 20:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11  3:06 linux-next: Tree for Oct 11 Stephen Rothwell
2012-10-11 16:34 ` [PATCH -next] staging: ramster: depends on NET Randy Dunlap
2012-10-11 20:10   ` Dan Magenheimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a20296e-60c2-4b03-b322-5ac060b38b52@default \
    --to=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox