linux-next: build warnings after merge of the pci tree

linux-next: build warnings after merge of the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3522 bytes --]

Hi all,

After merging the pci tree, today's linux-next build (htmldocs) produced
these warnings:

Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27.
Declaration is '.. c:function:: void __iomem *pci_iomap_range(struct pci_dev *dev, int bar, unsigned long offset, unsigned long maxlen)'.
Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27.
Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27.
Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27.
Declaration is '.. c:None:: unsigned long offset'.
Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C declaration, also defined at driver-api/device-io:27.
Declaration is '.. c:None:: unsigned long maxlen'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67.
Declaration is '.. c:function:: void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar, unsigned long offset, unsigned long maxlen)'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67.
Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67.
Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67.
Declaration is '.. c:None:: unsigned long offset'.
Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C declaration, also defined at driver-api/device-io:67.
Declaration is '.. c:None:: unsigned long maxlen'.
Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110.
Declaration is '.. c:function:: void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen)'.
Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110.
Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110.
Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C declaration, also defined at driver-api/device-io:110.
Declaration is '.. c:None:: unsigned long maxlen'.
Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131.
Declaration is '.. c:function:: void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long maxlen)'.
Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131.
Declaration is '.. c:None:: struct pci_dev *dev'.
Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131.
Declaration is '.. c:None:: int bar'.
Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C declaration, also defined at driver-api/device-io:131.
Declaration is '.. c:None:: unsigned long maxlen'.

Introduced by commit

  fbcc7d7f7948 ("PCI: Move pci_iomap.c to drivers/pci/")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the pci tree

[Philipp Stanner]

Hi,

On Mon, 2024-02-05 at 16:09 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pci tree, today's linux-next build (htmldocs)
> produced
> these warnings:
> 
> Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:27.
> Declaration is '.. c:function:: void __iomem *pci_iomap_range(struct
> pci_dev *dev, int bar, unsigned long offset, unsigned long maxlen)'.
> Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:27.
> Declaration is '.. c:None:: struct pci_dev *dev'.
> Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:27.
> Declaration is '.. c:None:: int bar'.
> Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:27.
> Declaration is '.. c:None:: unsigned long offset'.
> Documentation/driver-api/pci/pci.rst:27: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:27.
> Declaration is '.. c:None:: unsigned long maxlen'.
> Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:67.
> Declaration is '.. c:function:: void __iomem
> *pci_iomap_wc_range(struct pci_dev *dev, int bar, unsigned long
> offset, unsigned long maxlen)'.
> Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:67.
> Declaration is '.. c:None:: struct pci_dev *dev'.
> Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:67.
> Declaration is '.. c:None:: int bar'.
> Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:67.
> Declaration is '.. c:None:: unsigned long offset'.
> Documentation/driver-api/pci/pci.rst:67: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:67.
> Declaration is '.. c:None:: unsigned long maxlen'.
> Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:110.
> Declaration is '.. c:function:: void __iomem *pci_iomap(struct
> pci_dev *dev, int bar, unsigned long maxlen)'.
> Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:110.
> Declaration is '.. c:None:: struct pci_dev *dev'.
> Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:110.
> Declaration is '.. c:None:: int bar'.
> Documentation/driver-api/pci/pci.rst:110: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:110.
> Declaration is '.. c:None:: unsigned long maxlen'.
> Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:131.
> Declaration is '.. c:function:: void __iomem *pci_iomap_wc(struct
> pci_dev *dev, int bar, unsigned long maxlen)'.
> Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:131.
> Declaration is '.. c:None:: struct pci_dev *dev'.
> Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:131.
> Declaration is '.. c:None:: int bar'.
> Documentation/driver-api/pci/pci.rst:131: WARNING: Duplicate C
> declaration, also defined at driver-api/device-io:131.
> Declaration is '.. c:None:: unsigned long maxlen'.
> 
> Introduced by commit
> 
>   fbcc7d7f7948 ("PCI: Move pci_iomap.c to drivers/pci/")

Oh oh – Mea culpa. Will fix this.

I'd just ask for some direction how to fix it. My instinct would be to
just remove it from device-io.rst, since it's very PCI-specific; What
do you think?


P.

> 

linux-next: build warnings after merge of the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

After merging the pci tree, today's linux-next build (htmldocs) produced
these warnings:

Error: Cannot open file drivers/gpu/vga/vgaarb.c
Error: Cannot open file drivers/gpu/vga/vgaarb.c

Introduced by commit

  d6e1898bfa5b ("PCI/VGA: Move vgaarb to drivers/pci")

The reference in Documentation/gpu/vgaarbiter.rst needs to be updated.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the pci tree

[Bjorn Helgaas]

On Tue, Mar 01, 2022 at 01:59:38PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pci tree, today's linux-next build (htmldocs) produced
> these warnings:
> 
> Error: Cannot open file drivers/gpu/vga/vgaarb.c
> Error: Cannot open file drivers/gpu/vga/vgaarb.c
> 
> Introduced by commit
> 
>   d6e1898bfa5b ("PCI/VGA: Move vgaarb to drivers/pci")
> 
> The reference in Documentation/gpu/vgaarbiter.rst needs to be updated.

Fixed, thanks!

linux-next: build warnings after merge of the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

Hi Bjorn,

After merging the pci tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warning:

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_io_slot_reset':
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:11102:6: warning: unused variable 'err' [-Wunused-variable]
  int err;
      ^~~
drivers/net/ethernet/intel/i40e/i40e_main.c: In function 'i40e_pci_error_slot_reset':
drivers/net/ethernet/intel/i40e/i40e_main.c:14230:6: warning: unused variable 'err' [-Wunused-variable]
  int err;
      ^~~

also from the x86_64 allmodconfig build:

drivers/dma/ioat/init.c: In function 'ioat_pcie_error_slot_reset':
drivers/dma/ioat/init.c:1255:6: warning: unused variable 'err' [-Wunused-variable]
  int err;
      ^~~
drivers/net/ethernet/sfc/efx.c: In function 'efx_io_slot_reset':
drivers/net/ethernet/sfc/efx.c:3824:6: warning: unused variable 'rc' [-Wunused-variable]
  int rc;
      ^~
drivers/net/ethernet/sfc/falcon/efx.c: In function 'ef4_io_slot_reset':
drivers/net/ethernet/sfc/falcon/efx.c:3163:6: warning: unused variable 'rc' [-Wunused-variable]
  int rc;
      ^~

Introduced by commit

  6dcde3e574b2 ("XXX PCI/AER: Remove pci_cleanup_aer_uncorrect_error_status() calls")
(good subject prefix there :-))


-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the pci tree

[Bjorn Helgaas]

On Mon, Oct 1, 2018 at 7:26 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Bjorn,
>
> After merging the pci tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warning:
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_io_slot_reset':
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:11102:6: warning: unused variable 'err' [-Wunused-variable]
>   int err;
>       ^~~
> drivers/net/ethernet/intel/i40e/i40e_main.c: In function 'i40e_pci_error_slot_reset':
> drivers/net/ethernet/intel/i40e/i40e_main.c:14230:6: warning: unused variable 'err' [-Wunused-variable]
>   int err;
>       ^~~
>
> also from the x86_64 allmodconfig build:
>
> drivers/dma/ioat/init.c: In function 'ioat_pcie_error_slot_reset':
> drivers/dma/ioat/init.c:1255:6: warning: unused variable 'err' [-Wunused-variable]
>   int err;
>       ^~~
> drivers/net/ethernet/sfc/efx.c: In function 'efx_io_slot_reset':
> drivers/net/ethernet/sfc/efx.c:3824:6: warning: unused variable 'rc' [-Wunused-variable]
>   int rc;
>       ^~
> drivers/net/ethernet/sfc/falcon/efx.c: In function 'ef4_io_slot_reset':
> drivers/net/ethernet/sfc/falcon/efx.c:3163:6: warning: unused variable 'rc' [-Wunused-variable]
>   int rc;
>       ^~

Fixed the above, thanks!

> Introduced by commit
>
>   6dcde3e574b2 ("XXX PCI/AER: Remove pci_cleanup_aer_uncorrect_error_status() calls")
> (good subject prefix there :-))

Yeah, that's a note to self to update something in the changelog.

Bjorn

linux-next: build warnings after merge of the pci tree

[Stephen Rothwell]

Hi Bjorn,

After merging the pci tree, today's linux-next build (arm
multi_v7_defconfig) produced these warnings:

drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
   return err;
          ^
drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
   return PTR_ERR(cfg);
          ^
drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
  return err;
         ^

Introduced by commit

  3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the pci tree

[Bjorn Helgaas]

On Mon, Jun 20, 2016 at 11:52:13AM +1000, Stephen Rothwell wrote:
> Hi Bjorn,
> 
> After merging the pci tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warnings:
> 
> drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
> drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>    return err;
>           ^
> drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>    return PTR_ERR(cfg);
>           ^
> drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
>   return err;
>          ^
> 
> Introduced by commit
> 
>   3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated")

Fixed, thanks a lot, Stephen!

Re: linux-next: build warnings after merge of the pci tree

[Stephen Rothwell]

Hi Bjorn,

On Mon, 20 Jun 2016 14:11:36 -0500 Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Mon, Jun 20, 2016 at 11:52:13AM +1000, Stephen Rothwell wrote:
> > Hi Bjorn,
> > 
> > After merging the pci tree, today's linux-next build (arm
> > multi_v7_defconfig) produced these warnings:
> > 
> > drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
> > drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
> >    return err;
> >           ^
> > drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
> >    return PTR_ERR(cfg);
> >           ^
> > drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
> >   return err;
> >          ^
> > 
> > Introduced by commit
> > 
> >   3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated")  
> 
> Fixed, thanks a lot, Stephen!

Thanks.  Unfortunately, I still get this warning:

drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
   return PTR_ERR(cfg);
          ^

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the pci tree

[Bjorn Helgaas]

On Mon, Jun 20, 2016 at 8:08 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Bjorn,
>
> On Mon, 20 Jun 2016 14:11:36 -0500 Bjorn Helgaas <helgaas@kernel.org> wrote:
>>
>> On Mon, Jun 20, 2016 at 11:52:13AM +1000, Stephen Rothwell wrote:
>> > Hi Bjorn,
>> >
>> > After merging the pci tree, today's linux-next build (arm
>> > multi_v7_defconfig) produced these warnings:
>> >
>> > drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
>> > drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >    return err;
>> >           ^
>> > drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >    return PTR_ERR(cfg);
>> >           ^
>> > drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> >   return err;
>> >          ^
>> >
>> > Introduced by commit
>> >
>> >   3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated")
>>
>> Fixed, thanks a lot, Stephen!
>
> Thanks.  Unfortunately, I still get this warning:
>
> drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
> drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>    return PTR_ERR(cfg);
>           ^

Crap, sorry, PTR_ERR/ERR_PTR confusion.  I *think* I fixed it now.

Bjorn

Re: linux-next: build warnings after merge of the pci tree

[Narendra K]

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
> Sent: Monday, August 02, 2010 6:49 AM
> To: Jesse Barnes
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; K,
> Narendra; Hargrave, Jordan
> Subject: linux-next: build warnings after merge of the pci tree
> 
> Hi Jesse,
> 
> After merging the rr tree, today's linux-next build (powerpc
> ppc64_defconfig) produced lots of these warnings:
> 
> drivers/pci/pci.h: In function 'pci_create_firmware_label_files':
> drivers/pci/pci.h:16: warning: 'return' with a value, in function
> returning void
> drivers/pci/pci.h: In function 'pci_remove_firmware_label_files':
> drivers/pci/pci.h:18: warning: 'return' with a value, in function
> returning void
> 
> Introduced by commit 911e1c9b05a8e3559a7aa89083930700a0b9e7ee ("PCI:
> export SMBIOS provided firmware instance and label to sysfs").
> 
> Please build with and without the CONFIG options your new code depends
> on ...  This adds considerably to the build noise.

Jesse,

Sorry, I missed fixing these warnings that come when CONFIG_DMI is
unset. I have fixed them in the below patch. Please consider it for
inclusion.

From: Narendra K <narendra_k@dell.com>
Subject: [PATCH] PCI: Fix warnings when CONFIG_DMI unset

This patch fixes the below warnings introduced by the commit
911e1c9b05a8e3559a7aa89083930700a0b9e7ee ("PCI:
export SMBIOS provided firmware instance and label to sysfs").

drivers/pci/pci.h: In function ‘pci_create_firmware_label_files’:
drivers/pci/pci.h:16: warning: ‘return’ with a value, in function returning void
drivers/pci/pci.h: In function ‘pci_remove_firmware_label_files’:
drivers/pci/pci.h:18: warning: ‘return’ with a value, in function returning void

The warnings are seen because of the below code, doing a retun 0
from the functions 'pci_create_firmware_label_files' and
'pci_remove_firmware_label_files' defined as void.

+#ifndef CONFIG_DMI
+static inline void pci_create_firmware_label_files(struct pci_dev *pdev)
+{ return 0; }
+static inline void pci_remove_firmware_label_files(struct pci_dev *pdev)
+{ return 0; }

Signed-off-by: Narendra K <narendra_k@dell.com>
---
 drivers/pci/pci.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index d930338..95186ca 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -13,9 +13,9 @@ extern int pci_create_sysfs_dev_files(struct pci_dev *pdev);
 extern void pci_remove_sysfs_dev_files(struct pci_dev *pdev);
 #ifndef CONFIG_DMI
 static inline void pci_create_firmware_label_files(struct pci_dev *pdev)
-{ return 0; }
+{ return; }
 static inline void pci_remove_firmware_label_files(struct pci_dev *pdev)
-{ return 0; }
+{ return; }
 #else
 extern void pci_create_firmware_label_files(struct pci_dev *pdev);
 extern void pci_remove_firmware_label_files(struct pci_dev *pdev);
-- 
1.7.0.1

With regards,
Narendra K

linux-next: build warnings after merge of the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi Jesse,

After merging the rr tree, today's linux-next build (powerpc
ppc64_defconfig) produced lots of these warnings:

drivers/pci/pci.h: In function 'pci_create_firmware_label_files':
drivers/pci/pci.h:16: warning: 'return' with a value, in function returning void
drivers/pci/pci.h: In function 'pci_remove_firmware_label_files':
drivers/pci/pci.h:18: warning: 'return' with a value, in function returning void

Introduced by commit 911e1c9b05a8e3559a7aa89083930700a0b9e7ee ("PCI:
export SMBIOS provided firmware instance and label to sysfs").

Please build with and without the CONFIG options your new code depends
on ...  This adds considerably to the build noise.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warnings after merge of the pci tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi Jesse,

On Mon, 2 Aug 2010 11:18:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the rr tree, today's linux-next build (powerpc
                    ^^
I meant the pci tree, of course.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]