Re: [PATCH -next] 3c515: fix using pnp_get_resource when CONFIG_ISAPNP=n

Bjorn Helgaas
2008-05-16T18:58:01Z

On Friday 16 May 2008 12:21:35 pm Randy Dunlap wrote:
> Bjorn Helgaas wrote:
> > I prefer CONFIG_PNP to __ISAPNP__ in general, but I see
> > you're just following the other tests in the same file.
>
> Yes. And it would need to be CONFIG_ISAPNP, not CONFIG_PNP.

Huh. Sure enough. I hadn't even noticed pnp_find_dev().
I'm not sure why pnp_find_dev() should be under CONFIG_ISAPNP
rather than CONFIG_PNP, other than the fact that it uses
ISAPNP_ANY_ID.

On the other hand, there are only 25-30 users of pnp_find_dev();
maybe I should just look at converting them and nuking the
compat interfaces completely.

Bjorn