From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Miller <davem@davemloft.net>,
linux-next@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: linux-next: sparc64 build failure
Date: Fri, 30 May 2008 07:10:05 -0700 [thread overview]
Message-ID: <20080530141005.GB26342@kroah.com> (raw)
In-Reply-To: <20080530153847.a5f3fd35.sfr@canb.auug.org.au>
On Fri, May 30, 2008 at 03:38:47PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Thu, 29 May 2008 15:01:58 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > > - sprintf(pci_name(dev), "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> > > + dev_set_name(&dev->dev, "%04x:%02x:%02x.%d", pci_domain_nr(bus),
> > > dev->bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn));
> >
> > It's wierd that we broke the build like this, I'll work to merge this in
> > so that it isn't broken.
>
> It broke the build because arch/sparc64 is (mostly) built with -Werror.
Sorry, no, I realized that, I was confused as to why a warning was
created here. Turns out that pci_name() was being changed to a const
string, and the compiler was rightfully saying that we can't be using
that for an assignment.
I've fixed it up correctly in my latest tree, which you should have
already.
thanks,
greg k-h
next prev parent reply other threads:[~2008-05-30 14:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 7:53 linux-next: sparc64 build failure Stephen Rothwell
2008-05-29 22:01 ` Greg KH
2008-05-30 5:38 ` Stephen Rothwell
2008-05-30 14:10 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-20 0:43 Stephen Rothwell
2008-06-20 0:55 ` David Miller
2008-06-20 1:11 ` Stephen Rothwell
2008-06-20 7:34 ` Sam Ravnborg
2008-06-20 7:53 ` Stephen Rothwell
2008-06-20 8:34 ` Sam Ravnborg
2008-06-21 0:02 ` Stephen Rothwell
2008-07-08 9:08 Stephen Rothwell
2008-07-08 9:13 ` David Miller
2008-07-09 11:15 Stephen Rothwell
2008-07-09 21:23 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530141005.GB26342@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox