[PATCH -next] fork and exit: need to include iocontext.h

[PATCH -next] fork and exit: need to include iocontext.h

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix fork and exit build errors: they need to include iocontext.h:

linux-next-20080630/kernel/fork.c: In function 'copy_process':
linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
linux-next-20080630/kernel/exit.c: In function 'do_exit':
linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'


Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 kernel/exit.c |    1 +
 kernel/fork.c |    1 +
 2 files changed, 2 insertions(+)

--- linux-next-20080630.orig/kernel/fork.c
+++ linux-next-20080630/kernel/fork.c
@@ -23,6 +23,7 @@
 #include <linux/sem.h>
 #include <linux/file.h>
 #include <linux/fdtable.h>
+#include <linux/iocontext.h>
 #include <linux/key.h>
 #include <linux/binfmts.h>
 #include <linux/mman.h>
--- linux-next-20080630.orig/kernel/exit.c
+++ linux-next-20080630/kernel/exit.c
@@ -13,6 +13,7 @@
 #include <linux/personality.h>
 #include <linux/tty.h>
 #include <linux/mnt_namespace.h>
+#include <linux/iocontext.h>
 #include <linux/key.h>
 #include <linux/security.h>
 #include <linux/cpu.h>


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: [PATCH -next] fork and exit: need to include iocontext.h

[Ingo Molnar]

* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix fork and exit build errors: they need to include iocontext.h:
> 
> linux-next-20080630/kernel/fork.c: In function 'copy_process':
> linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> linux-next-20080630/kernel/exit.c: In function 'do_exit':
> linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'

i havent seen this one - do you know by chance which commit triggers it?

	Ingo

Re: [PATCH -next] fork and exit: need to include iocontext.h

[Randy Dunlap]

On Mon, 30 Jun 2008 20:05:06 +0200 Ingo Molnar wrote:

> 
> * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Fix fork and exit build errors: they need to include iocontext.h:
> > 
> > linux-next-20080630/kernel/fork.c: In function 'copy_process':
> > linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> > linux-next-20080630/kernel/exit.c: In function 'do_exit':
> > linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'
> 
> i havent seen this one - do you know by chance which commit triggers it?


Sorry, no idea which commit.

In 50 randconfigs today (next-20080630), I saw this one 12 times.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: [PATCH -next] fork and exit: need to include iocontext.h

[Ingo Molnar]

* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Mon, 30 Jun 2008 20:05:06 +0200 Ingo Molnar wrote:
> 
> > 
> > * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > 
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > 
> > > Fix fork and exit build errors: they need to include iocontext.h:
> > > 
> > > linux-next-20080630/kernel/fork.c: In function 'copy_process':
> > > linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> > > linux-next-20080630/kernel/exit.c: In function 'do_exit':
> > > linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'
> > 
> > i havent seen this one - do you know by chance which commit triggers it?
> 
> 
> Sorry, no idea which commit.
> 
> In 50 randconfigs today (next-20080630), I saw this one 12 times.

btw., block.git would be one of my first guesses - Jens Cc:-ed.

normally there's an easy way to find out the source commit of build 
failures. Try something like:

 git-bisect reset
 git-bisect start
 git-bisect good v2.6.26-rc8
 git-bisect bad linux-next/master
 git-bisect run make kernel/fork.o

... this should lead you to the commit that broke the build 
automatically. (as long as everyone keeps make oldconfig compatibility)

	Ingo

Re: [PATCH -next] fork and exit: need to include iocontext.h

[Randy Dunlap]

On Mon, 30 Jun 2008 20:33:37 +0200 Ingo Molnar wrote:

> 
> * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > On Mon, 30 Jun 2008 20:05:06 +0200 Ingo Molnar wrote:
> > 
> > > 
> > > * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > 
> > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > > 
> > > > Fix fork and exit build errors: they need to include iocontext.h:
> > > > 
> > > > linux-next-20080630/kernel/fork.c: In function 'copy_process':
> > > > linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> > > > linux-next-20080630/kernel/exit.c: In function 'do_exit':
> > > > linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'
> > > 
> > > i havent seen this one - do you know by chance which commit triggers it?
> > 
> > 
> > Sorry, no idea which commit.
> > 
> > In 50 randconfigs today (next-20080630), I saw this one 12 times.
> 
> btw., block.git would be one of my first guesses - Jens Cc:-ed.
> 
> normally there's an easy way to find out the source commit of build 
> failures. Try something like:
> 
>  git-bisect reset
>  git-bisect start
>  git-bisect good v2.6.26-rc8
>  git-bisect bad linux-next/master
>  git-bisect run make kernel/fork.o
> 
> ... this should lead you to the commit that broke the build 
> automatically. (as long as everyone keeps make oldconfig compatibility)

Thanks for the steps.  Maybe someday I'll use git.  ;)

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: [PATCH -next] fork and exit: need to include iocontext.h

[Ingo Molnar]

* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Mon, 30 Jun 2008 20:33:37 +0200 Ingo Molnar wrote:
> 
> > 
> > * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > 
> > > On Mon, 30 Jun 2008 20:05:06 +0200 Ingo Molnar wrote:
> > > 
> > > > 
> > > > * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > > 
> > > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > > > 
> > > > > Fix fork and exit build errors: they need to include iocontext.h:
> > > > > 
> > > > > linux-next-20080630/kernel/fork.c: In function 'copy_process':
> > > > > linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> > > > > linux-next-20080630/kernel/exit.c: In function 'do_exit':
> > > > > linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'
> > > > 
> > > > i havent seen this one - do you know by chance which commit triggers it?
> > > 
> > > 
> > > Sorry, no idea which commit.
> > > 
> > > In 50 randconfigs today (next-20080630), I saw this one 12 times.
> > 
> > btw., block.git would be one of my first guesses - Jens Cc:-ed.
> > 
> > normally there's an easy way to find out the source commit of build 
> > failures. Try something like:
> > 
> >  git-bisect reset
> >  git-bisect start
> >  git-bisect good v2.6.26-rc8
> >  git-bisect bad linux-next/master
> >  git-bisect run make kernel/fork.o
> > 
> > ... this should lead you to the commit that broke the build 
> > automatically. (as long as everyone keeps make oldconfig compatibility)
> 
> Thanks for the steps.  Maybe someday I'll use git.  ;)

goodies like this are the perfect receipe towards git-addiction ;-)

	Ingo

Re: [PATCH -next] fork and exit: need to include iocontext.h

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

On Mon, 30 Jun 2008 20:33:37 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>
> normally there's an easy way to find out the source commit of build 
> failures. Try something like:
> 
>  git-bisect reset
>  git-bisect start
>  git-bisect good v2.6.26-rc8

More generally "git-bisect good linux-next/stable" - the stable branch is
just where I started on Linus' tree and that is always good :-)

>  git-bisect bad linux-next/master
>  git-bisect run make kernel/fork.o
> 
> ... this should lead you to the commit that broke the build 
> automatically. (as long as everyone keeps make oldconfig compatibility)

Nice, I must try this.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH -next] fork and exit: need to include iocontext.h

[Jens Axboe]

On Mon, Jun 30 2008, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix fork and exit build errors: they need to include iocontext.h:
> 
> linux-next-20080630/kernel/fork.c: In function 'copy_process':
> linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> linux-next-20080630/kernel/exit.c: In function 'do_exit':
> linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'

Thanks Randy, I've updated the patch.

-- 
Jens Axboe