From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -next] fork and exit: need to include iocontext.h
Date: Mon, 30 Jun 2008 20:47:35 +0200
Message-ID: <20080630184735.GC20566@elte.hu>
References: <20080630105458.7c95e195.randy.dunlap@oracle.com> <20080630180506.GC23739@elte.hu> <20080630112222.f103e477.randy.dunlap@oracle.com> <20080630183337.GD32211@elte.hu> <20080630113956.d910a1d9.randy.dunlap@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-next-owner@vger.kernel.org>
Received: from mx2.mail.elte.hu ([157.181.151.9]:45606 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753369AbYF3SsX (ORCPT <rfc822;linux-next@vger.kernel.org>);
	Mon, 30 Jun 2008 14:48:23 -0400
Content-Disposition: inline
In-Reply-To: <20080630113956.d910a1d9.randy.dunlap@oracle.com>
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-next@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>, mingo <mingo@redhat.com>, tglx <tglx@linutronix.de>, hpa <hpa@zytor.com>, akpm <akpm@linux-foundation.org>, Jens Axboe <jens.axboe@oracle.com>


* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Mon, 30 Jun 2008 20:33:37 +0200 Ingo Molnar wrote:
> 
> > 
> > * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > 
> > > On Mon, 30 Jun 2008 20:05:06 +0200 Ingo Molnar wrote:
> > > 
> > > > 
> > > > * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > > 
> > > > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > > > 
> > > > > Fix fork and exit build errors: they need to include iocontext.h:
> > > > > 
> > > > > linux-next-20080630/kernel/fork.c: In function 'copy_process':
> > > > > linux-next-20080630/kernel/fork.c:1237: error: implicit declaration of function 'put_io_context'
> > > > > linux-next-20080630/kernel/exit.c: In function 'do_exit':
> > > > > linux-next-20080630/kernel/exit.c:992: error: implicit declaration of function 'exit_io_context'
> > > > 
> > > > i havent seen this one - do you know by chance which commit triggers it?
> > > 
> > > 
> > > Sorry, no idea which commit.
> > > 
> > > In 50 randconfigs today (next-20080630), I saw this one 12 times.
> > 
> > btw., block.git would be one of my first guesses - Jens Cc:-ed.
> > 
> > normally there's an easy way to find out the source commit of build 
> > failures. Try something like:
> > 
> >  git-bisect reset
> >  git-bisect start
> >  git-bisect good v2.6.26-rc8
> >  git-bisect bad linux-next/master
> >  git-bisect run make kernel/fork.o
> > 
> > ... this should lead you to the commit that broke the build 
> > automatically. (as long as everyone keeps make oldconfig compatibility)
> 
> Thanks for the steps.  Maybe someday I'll use git.  ;)

goodies like this are the perfect receipe towards git-addiction ;-)

	Ingo