From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: next-0630: sparc64: build failed Date: Tue, 1 Jul 2008 22:03:44 +0200 Message-ID: <20080701200344.GA4896@elte.hu> References: <20080701154648.GA31057@elte.hu> <486A7C19.5080905@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:59258 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbYGAUEF (ORCPT ); Tue, 1 Jul 2008 16:04:05 -0400 Content-Disposition: inline In-Reply-To: <486A7C19.5080905@gmail.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Abhishek Sagar Cc: David Miller , Alexander Beregalov , Linux Kernel Mailing List , linux-next@vger.kernel.org, sparclinux@vger.kernel.org, rostedt@goodmis.org * Abhishek Sagar wrote: > Hi Ingo/David, > > CONFIG_MCOUNT currently controls the compilation with -pg flag and the > export of _mcount. But with ftrace, the former is redundant and the > latter should be made unconditional since _mcount is always defined. > In which case, does the inlined patch (untested) make sense? It should > solve the build failure as well. hm, mcount is the facility - so it makes sense to have that defined. Here you basically hide CONFIG_MCOUNT: > -ifeq ($(CONFIG_MCOUNT),y) > - KBUILD_CFLAGS += -pg > +ifneq ($(CONFIG_FTRACE),y) > +ifeq ($(CONFIG_STACK_DEBUG),y) > +KBUILD_CFLAGS += -pg > +endif > endif via two conditions. I'm not sure that's a win and i found CONFIG_MCOUNT a logical switch - but it's David's call. Ingo