From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH 2/2] ACPI Check for backlight support via ACPI video.ko otherwise use vendor ACPI drivers Date: Thu, 3 Jul 2008 17:21:52 +0100 Message-ID: <20080703162152.GC29110@srcf.ucam.org> References: <200807031809.03172.trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:53933 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbYGCQV7 (ORCPT ); Thu, 3 Jul 2008 12:21:59 -0400 Content-Disposition: inline In-Reply-To: <200807031809.03172.trenn@suse.de> Sender: linux-next-owner@vger.kernel.org List-ID: To: Thomas Renninger Cc: ak@linux.intel.com, linux-acpi@vger.kernel.org, Henrique de Moraes Holschuh , Carlos Corbacho , Jonathan Woithe , malattia@linux.it, stelian@popies.net, linux-next@vger.kernel.org, Corentin CHARY , Lennart Poettering , Julia Jomantaite , corsac@debian.org, dannybaumann@web.de, marcus@better.se, Zhang Rui On Thu, Jul 03, 2008 at 06:08:59PM +0200, Thomas Renninger wrote: > + if (ACPI_SUCCESS(acpi_get_handle(device->handle, "DRDY", &h_dummy))) { > + ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Found IGD device\n")); > + video_caps |= ACPI_VIDEO_IGD; > + } In principle, it's possible for a vendor to implement opregion but not actually use it until the tche flags are set. If anyone's done that then you've just broken backlight control on their system. -- Matthew Garrett | mjg59@srcf.ucam.org