From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: ak@linux.intel.com, linux-acpi@vger.kernel.org,
linux-next@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Julia Jomantaite <julia.jomantaite@gmail.com>,
marcus@better.se, dannybaumann@web.de, corsac@debian.org
Subject: Re: [PATCH 1/2] ACPI Video: Ignore devices that aren't present in hardware
Date: Fri, 4 Jul 2008 11:18:06 +0100 [thread overview]
Message-ID: <20080704101806.GA9676@srcf.ucam.org> (raw)
In-Reply-To: <200807041208.04466.trenn@suse.de>
On Fri, Jul 04, 2008 at 12:08:02PM +0200, Thomas Renninger wrote:
> Hmm, there might be IGD devices that could just work with the default
> backlight functions...
> Your hint in the other mail to check for tche flag is a good one..
There are IGD devices that just work with the default functions. I'm
using one.
> As soon as your parts are finished we can easily remove the
> ACPI_VIDEO_IGD
> and add these graphics devices to the one which should be served by your
> modifications.
As I said, your patches (in their current form) *will* break systems
that currently work, and a quick check seems to indicate that that
includes my machine.
> Please explain me again why this should not go in before/with your patches.
> If we agree that this one (or a similar solution) makes sense I am going to
> post a 2nd version soon and then I can help a bit with the 750 ms issue...
The first patch should go in with the opregion code. The second patch
should go in without the IGD code. Can we please just fix this the right
way?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-07-04 10:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 16:05 [PATCH 1/2] ACPI Video: Ignore devices that aren't present in hardware Thomas Renninger
2008-07-03 16:08 ` Matthew Garrett
2008-07-03 16:15 ` Thomas Renninger
2008-07-03 16:16 ` Matthew Garrett
2008-07-03 16:21 ` Yves-Alexis Perez
2008-07-03 19:24 ` Matthew Garrett
2008-07-04 10:08 ` Thomas Renninger
2008-07-04 10:18 ` Matthew Garrett [this message]
2008-07-04 3:09 ` Henrique de Moraes Holschuh
2008-07-04 9:13 ` Matthew Garrett
2008-07-04 11:55 ` Henrique de Moraes Holschuh
2008-07-04 17:39 ` Matthew Garrett
2008-07-04 19:49 ` Henrique de Moraes Holschuh
2008-07-05 15:46 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080704101806.GA9676@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=corsac@debian.org \
--cc=dannybaumann@web.de \
--cc=julia.jomantaite@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=marcus@better.se \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).