From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH 2/2] ACPI Check for backlight support via ACPI video.ko otherwise use vendor ACPI drivers Date: Thu, 10 Jul 2008 12:19:00 +0100 Message-ID: <20080710111900.GA6303@srcf.ucam.org> References: <200807031809.03172.trenn@suse.de> <200807101300.37586.trenn@suse.de> <20080710110941.GC5017@srcf.ucam.org> <200807101315.21904.trenn@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:58079 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753589AbYGJLTE (ORCPT ); Thu, 10 Jul 2008 07:19:04 -0400 Content-Disposition: inline In-Reply-To: <200807101315.21904.trenn@suse.de> Sender: linux-next-owner@vger.kernel.org List-ID: To: Thomas Renninger Cc: ak@linux.intel.com, linux-acpi@vger.kernel.org, Henrique de Moraes Holschuh , Carlos Corbacho , Jonathan Woithe , malattia@linux.it, stelian@popies.net, linux-next@vger.kernel.org, Corentin CHARY , Lennart Poettering , Julia Jomantaite , corsac@debian.org, dannybaumann@web.de, marcus@better.se, Zhang Rui , Hong Liu On Thu, Jul 10, 2008 at 01:15:18PM +0200, Thomas Renninger wrote: > On Thursday 10 July 2008 13:09:41 Matthew Garrett wrote: > > No I didn't. Please don't do this - we have all the code needed to do it > > properly, so there's no need to use the thinkpad_acpi driver for > > backlight control on this hardware. > Ok. > But haven't you said there are ThinkPad BIOSes missing a specific ACPI part > and therefore you had the delay? > If you could give me a dmidecode output, I like to add it. > It would be great to have an example in the blacklist, then things are much > easier for others... No, I said that on Thinkpads with a PWM method, the PWM method has to be called in order to avoid the delay. There's no need for a blacklist. -- Matthew Garrett | mjg59@srcf.ucam.org