From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Renninger <trenn@suse.de>
Cc: ak@linux.intel.com, linux-acpi@vger.kernel.org,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Carlos Corbacho <carlos@strangeworlds.co.uk>,
Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
malattia@linux.it, stelian@popies.net,
linux-next@vger.kernel.org,
Corentin CHARY <corentincj@iksaif.net>,
Lennart Poettering <mzxreary@0pointer.de>,
Julia Jomantaite <julia.jomantaite@gmail.com>,
corsac@debian.org, dannybaumann@web.de, marcus@better.se,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH 2/2] ACPI Check for backlight support via ACPI video.ko otherwise use vendor ACPI drivers
Date: Thu, 10 Jul 2008 13:24:54 +0100 [thread overview]
Message-ID: <20080710122454.GA7584@srcf.ucam.org> (raw)
In-Reply-To: <200807101419.08524.trenn@suse.de>
On Thu, Jul 10, 2008 at 02:19:04PM +0200, Thomas Renninger wrote:
> On Thursday 10 July 2008 13:53:17 Matthew Garrett wrote:
> > If the ACPI video driver has bound, then using the dcdbas mechanism for
> > backlight control is incorrect. I wasn't aware that any Dells actually
> > implemented that. The correct thing is for userspace to stop using
> > dcdbas if a real backlight control is available, not to cripple the
> > ACPI video driver.
>
> Yes, I agree.
> Anyway, given the fact that video.ko was rather broken all the time, a
> reasonable solution for now is to exclude Dells from using it.
No, the problem was that the backlight was simultaneously being altered
by two pieces of code. kpowersave is doing the backlight control via hal
(I assume), and hal should simply not provide the Dell backlight control
on systems that have ACPI video backlight control. There's no need to
have this policy in the kernel.
> The dcdbas driver writers (I expect Dell itself has its finger on this one)
> should get informed and solution will be found. video_detect.c probably will
> help here.
It's a userspace problem and a straightforward userspace solution.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-07-10 12:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 16:08 [PATCH 2/2] ACPI Check for backlight support via ACPI video.ko otherwise use vendor ACPI drivers Thomas Renninger
2008-07-03 16:21 ` Matthew Garrett
2008-07-03 22:29 ` Matthew Garrett
2008-07-09 14:49 ` Thomas Renninger
2008-07-09 14:57 ` Matthew Garrett
2008-07-09 16:00 ` Thomas Renninger
2008-07-10 10:07 ` Matthew Garrett
2008-07-10 11:00 ` Thomas Renninger
2008-07-10 11:09 ` Matthew Garrett
2008-07-10 11:15 ` Thomas Renninger
2008-07-10 11:19 ` Matthew Garrett
2008-07-10 11:36 ` Thomas Renninger
2008-07-10 11:53 ` Matthew Garrett
2008-07-10 12:19 ` Thomas Renninger
2008-07-10 12:24 ` Matthew Garrett [this message]
2008-07-10 12:48 ` Thomas Renninger
2008-07-10 12:58 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710122454.GA7584@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=ak@linux.intel.com \
--cc=carlos@strangeworlds.co.uk \
--cc=corentincj@iksaif.net \
--cc=corsac@debian.org \
--cc=dannybaumann@web.de \
--cc=hmh@hmh.eng.br \
--cc=julia.jomantaite@gmail.com \
--cc=jwoithe@physics.adelaide.edu.au \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=malattia@linux.it \
--cc=marcus@better.se \
--cc=mzxreary@0pointer.de \
--cc=rui.zhang@intel.com \
--cc=stelian@popies.net \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).