linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: ak@linux.intel.com, linux-acpi@vger.kernel.org,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Carlos Corbacho <carlos@strangeworlds.co.uk>,
	Jonathan Woithe <jwoithe@physics.adelaide.edu.au>,
	malattia@linux.it, stelian@popies.net,
	linux-next@vger.kernel.org,
	Corentin CHARY <corentincj@iksaif.net>,
	Lennart Poettering <mzxreary@0pointer.de>,
	Julia Jomantaite <julia.jomantaite@gmail.com>,
	corsac@debian.org, dannybaumann@web.de, marcus@better.se,
	Zhang Rui <rui.zhang@intel.com>, Hong Liu <hong.liu@intel.com>
Subject: Re: [PATCH 2/2] ACPI Check for backlight support via ACPI video.ko otherwise use vendor ACPI drivers
Date: Thu, 10 Jul 2008 13:36:04 +0200	[thread overview]
Message-ID: <200807101336.08035.trenn@suse.de> (raw)
In-Reply-To: <20080710111900.GA6303@srcf.ucam.org>

On Thursday 10 July 2008 13:19:00 Matthew Garrett wrote:
> On Thu, Jul 10, 2008 at 01:15:18PM +0200, Thomas Renninger wrote:
> > On Thursday 10 July 2008 13:09:41 Matthew Garrett wrote:
> > > No I didn't. Please don't do this - we have all the code needed to do
> > > it properly, so there's no need to use the thinkpad_acpi driver for
> > > backlight control on this hardware.
> >
> > Ok.
> > But haven't you said there are ThinkPad BIOSes missing a specific ACPI
> > part and therefore you had the delay?
> > If you could give me a dmidecode output, I like to add it.
> > It would be great to have an example in the blacklist, then things are
> > much easier for others...
>
> No, I said that on Thinkpads with a PWM method, the PWM method has to be
> called in order to avoid the delay. There's no need for a blacklist.

Ok.
I just got a report that Dells must not use the video driver:
https://bugzilla.novell.com/show_bug.cgi?id=404627

They have a really ugly dcdbas driver which issues SMIs triggered from 
userspace.
Hmm, to do it correctly, I have to match against the alias of the dcdbas 
driver:
MODULE_ALIAS("dmi:*:[bs]vnD[Ee][Ll][Ll]*:*");
but matching for Dell should be enough.

Also not nice is that the video driver probably should not be loaded at all in 
this case.
Hmm, maybe I should check for !video_backlight_support 
&& !video_display_output_support and then do not load the video driver at 
all, it shouldn't have any functionality then, not sure...

   Thomas

  reply	other threads:[~2008-07-10 11:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03 16:08 [PATCH 2/2] ACPI Check for backlight support via ACPI video.ko otherwise use vendor ACPI drivers Thomas Renninger
2008-07-03 16:21 ` Matthew Garrett
2008-07-03 22:29   ` Matthew Garrett
2008-07-09 14:49   ` Thomas Renninger
2008-07-09 14:57     ` Matthew Garrett
2008-07-09 16:00       ` Thomas Renninger
2008-07-10 10:07         ` Matthew Garrett
2008-07-10 11:00           ` Thomas Renninger
2008-07-10 11:09             ` Matthew Garrett
2008-07-10 11:15               ` Thomas Renninger
2008-07-10 11:19                 ` Matthew Garrett
2008-07-10 11:36                   ` Thomas Renninger [this message]
2008-07-10 11:53                     ` Matthew Garrett
2008-07-10 12:19                       ` Thomas Renninger
2008-07-10 12:24                         ` Matthew Garrett
2008-07-10 12:48                           ` Thomas Renninger
2008-07-10 12:58                             ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807101336.08035.trenn@suse.de \
    --to=trenn@suse.de \
    --cc=ak@linux.intel.com \
    --cc=carlos@strangeworlds.co.uk \
    --cc=corentincj@iksaif.net \
    --cc=corsac@debian.org \
    --cc=dannybaumann@web.de \
    --cc=hmh@hmh.eng.br \
    --cc=hong.liu@intel.com \
    --cc=julia.jomantaite@gmail.com \
    --cc=jwoithe@physics.adelaide.edu.au \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=marcus@better.se \
    --cc=mjg59@srcf.ucam.org \
    --cc=mzxreary@0pointer.de \
    --cc=rui.zhang@intel.com \
    --cc=stelian@popies.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).