From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Milton Miller <miltonm@bga.com>, Ingo Molnar <mingo@redhat.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace
Date: Fri, 11 Jul 2008 22:34:00 +1000 [thread overview]
Message-ID: <200807112234.00993.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080711074602.GB27849@elte.hu>
On Friday 11 July 2008 17:46:03 Ingo Molnar wrote:
> * Milton Miller <miltonm@bga.com> wrote:
> > Hi Rusty, Ingo.
> >
> > Rusty's patch [PATCH 3/3] stop_machine: use cpu mask rather than magic
> > numbers didn't find kernel/trace/ftrace.c in -next, causing an
> > immediate almost NULL pointer dereference in ftrace_dynamic_init.
>
> Rusty - what's going on here? Please do not change APIs like that, which
> cause code to crash. Either do a compatible API change, or change it
> over in a way that causes clear build failures, not crashes.
To be fair, I did. Unfortunately GCC only warns about passing an int to a
pointer arg, and boom.
But compatible is even better. Given the number of stop_machine_run users I
thought it unlikely that a new one would be introduced during the change. I
was wrong, so I'll do it the Right Way.
Cheers,
Rusty.
prev parent reply other threads:[~2008-07-11 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200807081750.55536.rusty@rustcorp.com.au>
[not found] ` <200807081756.02838.rusty@rustcorp.com.au>
[not found] ` <200807081756.47140.rusty@rustcorp.com.au>
[not found] ` <200807081801.38026.rusty@rustcorp.com.au>
2008-07-10 21:07 ` [PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace Milton Miller
2008-07-11 6:43 ` Rusty Russell
2008-07-11 7:46 ` Ingo Molnar
2008-07-11 8:55 ` Ingo Molnar
2008-07-11 12:34 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807112234.00993.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).