From: Al Viro <viro@ZenIV.linux.org.uk>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
linux-next <linux-next@vger.kernel.org>
Subject: Re: [PATCH] gfs2: remove nameidata arg from gfs_iop_permission
Date: Fri, 18 Jul 2008 18:23:08 +0100 [thread overview]
Message-ID: <20080718172308.GQ28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1216398403.6029.145.camel@brick>
On Fri, Jul 18, 2008 at 09:26:42AM -0700, Harvey Harrison wrote:
> Noticed by sparse
> > fs/gfs2/ops_inode.c:1153:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1153:16: expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1153:16: got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1172:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1172:16: expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1172:16: got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1184:16: warning: incorrect type in initializer (different argument counts)
> > fs/gfs2/ops_inode.c:1184:16: expected int ( *permission )( ... )
> > fs/gfs2/ops_inode.c:1184:16: got int ( static [toplevel] *<noident> )( ... )
> > fs/gfs2/ops_inode.c:1153: warning: initialization from incompatible pointer type
> > fs/gfs2/ops_inode.c:1172: warning: initialization from incompatible pointer type
> > fs/gfs2/ops_inode.c:1184: warning: initialization from incompatible pointer type
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Appeared between next-20080716 and next-20080717
>
> fs/gfs2/ops_inode.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index 1e252df..0456e2b 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -915,8 +915,7 @@ int gfs2_permission(struct inode *inode, int mask)
> return error;
> }
>
> -static int gfs2_iop_permission(struct inode *inode, int mask,
> - struct nameidata *nd)
> +static int gfs2_iop_permission(struct inode *inode, int mask)
> {
> return gfs2_permission(inode, mask);
> }
Er? Commit c0beafa477f3f59d0f27c477f9b7f97498f2f96a kills the function
completely; what tree are you working with?
next prev parent reply other threads:[~2008-07-18 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 21:08 GFS2: new warnings in -next Harvey Harrison
2008-07-18 16:26 ` [PATCH] gfs2: remove nameidata arg from gfs_iop_permission Harvey Harrison
2008-07-18 17:23 ` Al Viro [this message]
2008-07-18 17:30 ` Harvey Harrison
2008-07-18 18:04 ` Al Viro
2008-07-18 18:22 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718172308.GQ28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=harvey.harrison@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).