From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-next@vger.kernel.org, Jaswinder Singh <jaswinder@infradead.org>
Subject: linux-next: firmware tree build failure
Date: Tue, 22 Jul 2008 18:04:16 +1000 [thread overview]
Message-ID: <20080722180416.67461eae.sfr@canb.auug.org.au> (raw)
Hi Dave,
Today's linux-next build (sparc32 defconfig) failed like this:
drivers/scsi/qlogicpti.c: In function `qlogicpti_load_firmware':
drivers/scsi/qlogicpti.c:476: error: structure has no member named `sbus'
I applied the following patch.
I think we can conclude that this was never build tested. :-(
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
>From 6c5369981d0b90c76286263dfca0e94b3987f9d8 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 22 Jul 2008 18:02:15 +1000
Subject: [PATCH] firmware: another typo in the conversion
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/scsi/qlogicpti.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 17df63e..1b6594e 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -473,7 +473,7 @@ static int __devinit qlogicpti_load_firmware(struct qlogicpti *qpti)
unsigned long flags;
int i, timeout;
- err = request_firmware(&fw, fwname, &qpti->sbus->ofdev.dev);
+ err = request_firmware(&fw, fwname, &qpti->sdev->ofdev.dev);
if (err) {
printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
fwname, err);
--
1.5.6.3
next reply other threads:[~2008-07-22 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 8:04 Stephen Rothwell [this message]
2008-07-22 8:25 ` linux-next: firmware tree build failure Jaswinder Singh
-- strict thread matches above, loose matches on Subject: below --
2009-04-14 4:12 Stephen Rothwell
2009-04-14 12:25 ` David Woodhouse
2009-04-15 1:56 ` David Woodhouse
2009-04-15 2:03 ` Stephen Rothwell
2008-07-22 7:57 Stephen Rothwell
2008-07-22 7:47 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722180416.67461eae.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dwmw2@infradead.org \
--cc=jaswinder@infradead.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox