From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-next@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 00/12] Thumb-2 kernel support
Date: Sun, 27 Jul 2008 12:08:05 +0100 [thread overview]
Message-ID: <20080727110804.GE32366@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080723151045.bcae107e.akpm@linux-foundation.org>
On Wed, Jul 23, 2008 at 03:10:45PM -0700, Andrew Morton wrote:
> Well. Rather than doing things sequentially we could go parallel.
> Russell could say "I'll look at them before 2.6.28 but please put them
> into linux-next meanwhile".
There have been some valid but (iirc) non-vocal objections to the
Thumb-2 support from a few people. The biggest one is all the
mess associated with supporting this "unified" assembler stuff.
My view is that I really don't like these patches; they make the
code very unreadable and more prone to errors. They're going to
cause us lots of problems in the future. Every git merge which
touches any ARM file containing assembly is going to have to be
_very_ carefully reviewed, and it's not always possible to catch
all of those.
The only suggestion I have to improving the situation is to recommend
that someone rethinks their wizzy new assembly language format - which
IMHO is currently only fit for "write once, read or modify never"
assembly code.
next prev parent reply other threads:[~2008-07-27 11:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080606173300.7930.31525.stgit@pc1117.cambridge.arm.com>
2008-06-30 19:51 ` [PATCH 00/12] Thumb-2 kernel support Andrew Morton
2008-07-01 8:32 ` Catalin Marinas
2008-07-01 8:45 ` Andrew Morton
2008-07-23 16:05 ` Catalin Marinas
2008-07-23 20:01 ` Andrew Morton
2008-07-23 21:10 ` Catalin Marinas
2008-07-23 22:10 ` Andrew Morton
2008-07-24 8:28 ` Catalin Marinas
2008-07-27 11:08 ` Russell King - ARM Linux [this message]
2008-07-28 11:45 ` Catalin Marinas
2008-07-28 12:40 ` Catalin Marinas
2008-07-28 12:53 ` Russell King - ARM Linux
2008-08-12 2:07 ` Nicolas Pitre
2008-07-28 12:50 ` Russell King - ARM Linux
2008-07-28 14:41 ` Catalin Marinas
2008-08-12 2:17 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080727110804.GE32366@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).