From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: linux-next: build failure Date: Wed, 30 Jul 2008 21:16:55 +0200 Message-ID: <200807302116.55515.bzolnier@gmail.com> References: <20080730153028.95226354.sfr@canb.auug.org.au> <20080730064146.GA1564@cs181140183.pp.htv.fi> <20080730070643.GA18347@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080730070643.GA18347-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Ankita Garg Cc: Stephen Rothwell , Adrian Bunk , Ananth N Mavinakayanahalli , kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Haren Myneni , linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vivek Goyal List-Id: linux-next.vger.kernel.org On Wednesday 30 July 2008, Ankita Garg wrote: > On Wed, Jul 30, 2008 at 09:41:46AM +0300, Adrian Bunk wrote: > > On Wed, Jul 30, 2008 at 03:30:28PM +1000, Stephen Rothwell wrote: > > > Hi Ananth, > > > > > > Today's linux-next build (powerpc allyesconfig) failed like this: > > > > > > tests/lkdtm.c:182: error: expected ')' before '*' token > > > > > > I have no idea why this fails now when it did not before. > > > > Sorry, that's my fault. > > (I didn't notice since my allyes builds have CONFIG_MODULES=n, and > > no defconfig seems to have both LKDTM and IDE=y.) > > > > Bart, can you either apply Stephen's patch or drop the lkdtm.c chunk > > from my patch? > > > > I suppose it would be better if the earlier changes are reverted, as > lkdtm already has bits to include ide.h depending on CONFIG_IDE being > y/n. I reverted lktdm.c change (sorry for not noticing it earlier). Thanks, Bart