From: Rui Sousa <rui.p.m.sousa@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org
Subject: Re: linux-next: tip-core build failure
Date: Mon, 15 Sep 2008 15:02:48 +0200 [thread overview]
Message-ID: <200809151502.48849.rui.p.m.sousa@gmail.com> (raw)
In-Reply-To: <20080915081129.GD29585@elte.hu>
On Monday 15 September 2008 10:11, Ingo Molnar wrote:
> * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi Ingo,
> >
> > On Sun, 14 Sep 2008 21:17:09 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> > > * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > > On Sun, 14 Sep 2008 20:36:29 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> > > > > [ ... just used by 90%+ of our active testers/developers ;-) ... ]
> > > >
> > > > An irrelevant argument in this case.
> > >
> > > why is the actual usage distribution of Linux irrelevant? We make
> >
> > Notice the "in this case"? In this case the code being changed
> > clearly could affect other architectures, so checking that x86 is OK
> > is clearly not enough (and that does not mean building it for 20+
> > other architectures, just using grep to see the consequences of the
> > change and maybe discussing it with the affected architecture
> > maintainers or on linux-arch).
>
> again, the side effects were not realized. Pretty much _any_ patch that
> is not strictly restricted to a single architecture 'could' affect other
> architectures. Any change to a common .h or .c file could do that - and
> 90% of Linux's source code is in common files.
>
> Hence your suggestion that we should have found this breakage makes no
> sense in practice as it's not reliably testable.
>
> Yes, for things like sparseirq support we pretty much expected
> cross-arch fallout so we checked a ton of architectures. For other
> patches bugs can slip through, and that's OK as we really dont want to
> dog down pretty much every patch with the requirement to cross-build.
>
> Ingo
Hi,
I have just subscribed to linux-arch and will work on a patch updating all
archictures. Once I have it I will post it on the list for discussion/review.
One thing that would be nice, but I don't see how it can be done in practice,
is to have a public server, where people can submit their patches and at least
make sure they compile on all archictetures.
Thanks,
Rui
prev parent reply other threads:[~2008-09-15 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 1:14 linux-next: tip-core build failure Stephen Rothwell
2008-09-13 9:44 ` Rui Sousa
2008-09-14 12:43 ` Ingo Molnar
2008-09-14 18:01 ` Stephen Rothwell
2008-09-14 18:36 ` Ingo Molnar
2008-09-14 19:02 ` Stephen Rothwell
2008-09-14 19:17 ` Ingo Molnar
2008-09-14 19:45 ` Stephen Rothwell
2008-09-15 8:11 ` Ingo Molnar
2008-09-15 13:02 ` Rui Sousa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809151502.48849.rui.p.m.sousa@gmail.com \
--to=rui.p.m.sousa@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox