From: Russell King <rmk@arm.linux.org.uk>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org
Subject: Re: linux-next: arm tree build failure
Date: Thu, 18 Sep 2008 23:04:57 +0100 [thread overview]
Message-ID: <20080918220457.GC17688@flint.arm.linux.org.uk> (raw)
In-Reply-To: <f17812d70809181133ha833a5ewbdcea402dccfea92@mail.gmail.com>
On Fri, Sep 19, 2008 at 02:33:02AM +0800, Eric Miao wrote:
> On Fri, Sep 19, 2008 at 2:26 AM, Eric Miao <eric.y.miao@gmail.com> wrote:
> >> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> >> index 8854dbb..361240a 100644
> >> --- a/drivers/video/backlight/Kconfig
> >> +++ b/drivers/video/backlight/Kconfig
> >> @@ -27,6 +27,7 @@ config LCD_CLASS_DEVICE
> >> config LCD_CORGI
> >> tristate "LCD Panel support for SHARP corgi/spitz model"
> >> depends on LCD_CLASS_DEVICE && SPI_MASTER
> >> + depends on ARM
> >
> > I think a "depends on PXA_SHARPSL" would be more precise here.
> >
> >> default n
> >> help
> >> Say y here to support the LCD panels usually found on SHARP
> >
>
> Russell,
>
> Since the patch titled:
>
> "lcd: add SPI-based LCD and backlight driver for SHARP corgi/spitz"
>
> is merged in your tree, and I don't know if it hits the mainline or not
> (most likely not), I'd suggest to merge this into that one with Stephen's
> Signed-off-by. Would you please do that at your convenience, or let
> me know if you would like me to.
I've added your suggested change instead (PXA_SHARPSL makes much more
sense) so it doesn't require any additional sign-offs. Will push it
out in about half an hour.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-09-18 22:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 18:09 linux-next: arm tree build failure Stephen Rothwell
2008-09-18 18:26 ` Eric Miao
2008-09-18 18:33 ` Eric Miao
2008-09-18 22:04 ` Russell King [this message]
2008-09-18 22:28 ` Eric Miao
-- strict thread matches above, loose matches on Subject: below --
2010-01-28 23:38 Stephen Rothwell
2010-01-29 23:45 ` Russell King
2010-01-30 1:27 ` Stephen Rothwell
2009-09-10 4:59 Stephen Rothwell
2009-09-14 8:20 ` Russell King
2009-04-14 7:48 Stephen Rothwell
2009-04-14 17:09 ` Russell King
2009-02-14 4:27 Stephen Rothwell
2009-02-16 9:23 ` Catalin Marinas
2008-08-19 5:53 Stephen Rothwell
2008-08-19 11:16 ` Marek Vasut
2008-08-19 11:21 ` Takashi Iwai
2008-08-19 16:06 ` Russell King
2008-08-19 16:32 ` Takashi Iwai
2008-08-20 0:01 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918220457.GC17688@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=eric.y.miao@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).