From: Dave Chinner <david@fromorbit.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-next@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Lachlan McIlroy <lachlan@sgi.com>
Subject: Re: linux-next: vfs tree build failure
Date: Mon, 20 Oct 2008 18:13:38 +1100 [thread overview]
Message-ID: <20081020071338.GQ31761@disturbed> (raw)
In-Reply-To: <20081020171830.9ece287f.sfr@canb.auug.org.au>
On Mon, Oct 20, 2008 at 05:18:30PM +1100, Stephen Rothwell wrote:
> Hi Al,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> fs/xfs/linux-2.6/xfs_export.c: In function 'xfs_fs_get_parent':
> fs/xfs/linux-2.6/xfs_export.c:201: error: incompatible type for argument 1 of 'd_obtain_alias'
.....
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> fs/xfs/linux-2.6/xfs_export.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/xfs/linux-2.6/xfs_export.c b/fs/xfs/linux-2.6/xfs_export.c
> index 263027f..dd71e86 100644
> --- a/fs/xfs/linux-2.6/xfs_export.c
> +++ b/fs/xfs/linux-2.6/xfs_export.c
> @@ -198,7 +198,7 @@ xfs_fs_get_parent(
> if (unlikely(error))
> return ERR_PTR(-error);
>
> - return d_obtain_alias(cip->i_vnode);
> + return d_obtain_alias(&cip->i_vnode);
> }
Hmmmm - looks like the VFS patches aren't using the correct
accessor function like the original code did. The fix should
be:
+ return d_obtain_alias(VFS_I(cip));
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-20 7:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 6:18 linux-next: vfs tree build failure Stephen Rothwell
2008-10-20 7:13 ` Dave Chinner [this message]
2008-10-20 7:40 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-01-28 1:00 Stephen Rothwell
2010-01-28 1:54 ` Al Viro
2010-01-27 0:37 Stephen Rothwell
2009-05-07 3:53 Stephen Rothwell
2009-05-07 4:04 ` Al Viro
2009-04-02 2:12 Stephen Rothwell
2009-04-03 4:43 ` Stephen Rothwell
2009-04-02 1:52 Stephen Rothwell
2009-04-03 4:44 ` Stephen Rothwell
2008-10-15 6:49 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020071338.GQ31761@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).